From: "J. Bruce Fields" <bfields@fieldses.org>
To: andros@netapp.com
Cc: trondmy.myklebust@primarydata.com, anna.schumaker@netapp.com,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH Version-2 00/12] NFSv4.2 inter server to server copy
Date: Fri, 19 Aug 2016 17:26:01 -0400 [thread overview]
Message-ID: <20160819212601.GT32329@fieldses.org> (raw)
In-Reply-To: <1471627512-4102-1-git-send-email-andros@netapp.com>
I may not be able to review this carefully for a while.
Some general questions:
- how are you testing this?
- have you done any performance testing, and if so do you seem
to be getting expected bandwidth on the server-to-server copy?
- is there wireshark support for the client-to-server and
server-to-server protocol?
- how is the source server authorizing the copy? Is GSSv3 still
needed for this eventually?
--b.
On Fri, Aug 19, 2016 at 01:25:00PM -0400, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
>
>
> Anna's patches applied first:
> The first patch is a bug fix from Anna for the upstream Intra
> server to server copy.
>
> The second patch has been submitted upstream, and is being
> reviewed by Bruce Fields.
>
> The rest of the patches implement NFSv4.2 Intra-SSC
>
>
> Andy Adamson (9):
> VFS permit cross device vfs_copy_file_range
> NFS inter ssc open
> NFS add COPY_NOTIFY operation
> NFS add ca_source_server<> to COPY
> NFSD add ca_source_server<> to COPY
> NFSD add COPY_NOTIFY operation
> NFSD generalize nfsd4_compound_state flag names
> NFSD: allow inter server COPY to have a STALE source server fh
> NFSD add nfs4 inter ssc to nfsd4_copy
>
> Anna Schumaker (2):
> fs: Don't copy beyond the end of the file
> NFSD: Implement the COPY call
>
> Olga Kornievskaia (1):
> NFSD: extra stateid checking in read for interserver copy
>
> fs/nfs/internal.h | 10 +
> fs/nfs/nfs42.h | 7 +-
> fs/nfs/nfs42proc.c | 128 ++++++++++-
> fs/nfs/nfs42xdr.c | 205 +++++++++++++++++-
> fs/nfs/nfs4_fs.h | 8 +
> fs/nfs/nfs4file.c | 135 +++++++++++-
> fs/nfs/nfs4proc.c | 6 +-
> fs/nfs/nfs4state.c | 2 +-
> fs/nfs/nfs4xdr.c | 1 +
> fs/nfsd/Kconfig | 10 +
> fs/nfsd/nfs4proc.c | 527 ++++++++++++++++++++++++++++++++++++++++++++--
> fs/nfsd/nfs4state.c | 47 ++++-
> fs/nfsd/nfs4xdr.c | 272 +++++++++++++++++++++++-
> fs/nfsd/nfsd.h | 2 +
> fs/nfsd/state.h | 8 +
> fs/nfsd/vfs.c | 6 +
> fs/nfsd/vfs.h | 2 +
> fs/nfsd/xdr4.h | 50 ++++-
> fs/read_write.c | 8 +-
> include/linux/nfs4.h | 43 ++++
> include/linux/nfs_fs_sb.h | 1 +
> include/linux/nfs_xdr.h | 20 ++
> 22 files changed, 1443 insertions(+), 55 deletions(-)
>
> --
> 1.8.3.1
prev parent reply other threads:[~2016-08-19 21:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 17:25 [PATCH Version-2 00/12] NFSv4.2 inter server to server copy andros
2016-08-19 17:25 ` [PATCH Version-2 01/12] fs: Don't copy beyond the end of the file andros
2016-08-20 6:19 ` Christoph Hellwig
2016-08-19 17:25 ` [PATCH Version-2 02/12] NFSD: Implement the COPY call andros
2016-08-19 17:25 ` [PATCH Version-2 03/12] VFS permit cross device vfs_copy_file_range andros
2016-08-19 21:08 ` J. Bruce Fields
2016-08-20 6:18 ` Christoph Hellwig
2016-08-22 19:27 ` J. Bruce Fields
2016-08-24 18:38 ` Adamson, Andy
2016-08-19 17:25 ` [PATCH Version-2 04/12] NFS inter ssc open andros
2016-08-19 21:11 ` J. Bruce Fields
2016-08-19 17:25 ` [PATCH Version-2 05/12] NFS add COPY_NOTIFY operation andros
2016-08-19 17:25 ` [PATCH Version-2 06/12] NFS add ca_source_server<> to COPY andros
2016-08-19 17:25 ` [PATCH Version-2 07/12] NFSD " andros
2016-08-19 17:25 ` [PATCH Version-2 08/12] NFSD add COPY_NOTIFY operation andros
2016-08-19 17:25 ` [PATCH Version-2 09/12] NFSD generalize nfsd4_compound_state flag names andros
2016-08-19 17:25 ` [PATCH Version-2 10/12] NFSD: allow inter server COPY to have a STALE source server fh andros
2016-08-19 17:25 ` [PATCH Version-2 11/12] NFSD add nfs4 inter ssc to nfsd4_copy andros
2016-08-19 17:25 ` [PATCH Version-2 12/12] NFSD: extra stateid checking in read for interserver copy andros
2016-08-19 21:26 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819212601.GT32329@fieldses.org \
--to=bfields@fieldses.org \
--cc=andros@netapp.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).