From: Eryu Guan <eguan@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>,
fstests@vger.kernel.org, linux-nfs@vger.kernel.org,
hch@infradead.org
Subject: Re: [PATCH v2 1/4] generic/377: Add copy to new file test
Date: Fri, 9 Sep 2016 15:01:46 +0800 [thread overview]
Message-ID: <20160909070146.GZ27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160909062925.GC9312@birch.djwong.org>
On Thu, Sep 08, 2016 at 11:29:25PM -0700, Darrick J. Wong wrote:
> > > +
> > > +_require_xfs_io_command "copy_range"
> >
> > Do we need to test the support status on kernel side? e.g. what happens
> > if filesystems have no "copy_file_range" implemented? Seems
> > copy_file_range falls back to splice in this case, but I'm not sure. If
> > so I think it's OK to have no kernel side detection.
>
> But... it's a totally new syscall, so _require_io_command should actually try
> calling it so that we can _notrun on old kernels.
The only reason that I think it's OK to check xfs_io support only is
that the "copy_range" subcommand won't be even compiled in xfs_io if
kernel has no copy_file_range syscall support.
But yeah, I agree that calling it and see how kernel handles it would be
the best option, like how we handle falloc, fpunch in
_require_xfs_io_command.
Thanks,
Eryu
next prev parent reply other threads:[~2016-09-09 7:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 19:56 [PATCH v2 0/4] Add copy_file_range() tests Anna Schumaker
2016-09-07 19:56 ` [PATCH v2 1/4] generic/377: Add copy to new file test Anna Schumaker
2016-09-09 6:21 ` Eryu Guan
2016-09-09 6:29 ` Darrick J. Wong
2016-09-09 7:01 ` Eryu Guan [this message]
2016-09-11 23:10 ` Dave Chinner
2016-09-07 19:56 ` [PATCH v2 2/4] generic/378: Add small copies " Anna Schumaker
2016-09-07 19:56 ` [PATCH v2 3/4] generic/379: Add copy test that overwrites data Anna Schumaker
2016-09-07 19:56 ` [PATCH v2 4/4] generic/380: Add a copy test for overwriting small amounts of data Anna Schumaker
2016-09-17 17:03 ` [PATCH v2 0/4] Add copy_file_range() tests Darrick J. Wong
2016-10-26 8:26 ` Christoph Hellwig
2016-11-25 8:05 ` Christoph Hellwig
2016-11-29 20:47 ` J. Bruce Fields
2016-11-29 20:59 ` Anna Schumaker
2016-11-29 23:21 ` Darrick J. Wong
2016-12-02 20:00 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909070146.GZ27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=Anna.Schumaker@netapp.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).