From: kbuild test robot <lkp@intel.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: kbuild-all@01.org, anna.schumaker@netapp.com,
linux-nfs@vger.kernel.org, Oleg Drokin <green@linuxhacker.ru>
Subject: Re: [PATCH v4 20/20] NFSv4: Fix a race when updating an open_stateid
Date: Fri, 16 Sep 2016 06:17:11 +0800 [thread overview]
Message-ID: <201609160640.LCbdSjO1%fengguang.wu@intel.com> (raw)
In-Reply-To: <1473957960-10001-21-git-send-email-trond.myklebust@primarydata.com>
[-- Attachment #1: Type: text/plain, Size: 2420 bytes --]
Hi Trond,
[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v4.8-rc6 next-20160915]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url: https://github.com/0day-ci/linux/commits/Trond-Myklebust/Fix-delegation-behaviour-when-server-revokes-some-state/20160916-050650
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
fs/nfs/nfs4proc.c: In function 'update_open_stateid':
>> fs/nfs/nfs4proc.c:1524:2: warning: missing braces around initializer [-Wmissing-braces]
nfs4_stateid freeme = {0};
^
fs/nfs/nfs4proc.c:1524:2: warning: (near initialization for 'freeme.<anonymous>') [-Wmissing-braces]
vim +1524 fs/nfs/nfs4proc.c
1508 if (open_stateid != NULL)
1509 nfs_set_open_stateid_locked(state, open_stateid, fmode, freeme);
1510 write_sequnlock(&state->seqlock);
1511 update_open_stateflags(state, fmode);
1512 spin_unlock(&state->owner->so_lock);
1513 }
1514
1515 static int update_open_stateid(struct nfs4_state *state,
1516 const nfs4_stateid *open_stateid,
1517 const nfs4_stateid *delegation,
1518 fmode_t fmode)
1519 {
1520 struct nfs_server *server = NFS_SERVER(state->inode);
1521 struct nfs_client *clp = server->nfs_client;
1522 struct nfs_inode *nfsi = NFS_I(state->inode);
1523 struct nfs_delegation *deleg_cur;
> 1524 nfs4_stateid freeme = {0};
1525 int ret = 0;
1526
1527 fmode &= (FMODE_READ|FMODE_WRITE);
1528
1529 rcu_read_lock();
1530 deleg_cur = rcu_dereference(nfsi->delegation);
1531 if (deleg_cur == NULL)
1532 goto no_delegation;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 11444 bytes --]
next prev parent reply other threads:[~2016-09-15 22:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 16:45 [PATCH v4 00/20] Fix delegation behaviour when server revokes some state Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 01/20] NFSv4.1: Don't deadlock the state manager on the SEQUENCE status flags Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 02/20] NFSv4.1: Don't check delegations that are already marked as revoked Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 03/20] NFSv4.1: Allow test_stateid to handle session errors without waiting Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 04/20] NFSv4.1: Add a helper function to deal with expired stateids Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 05/20] NFSv4.x: Allow callers of nfs_remove_bad_delegation() to specify a stateid Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 06/20] NFSv4.1: Test delegation stateids when server declares "some state revoked" Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 07/20] NFSv4.1: Deal with server reboots during delegation expiration recovery Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 08/20] NFSv4.1: Don't recheck delegations that have already been checked Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 09/20] NFSv4.1: Allow revoked stateids to skip the call to TEST_STATEID Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 10/20] NFSv4.1: Ensure we always run TEST/FREE_STATEID on locks Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 11/20] NFSv4.1: FREE_STATEID can be asynchronous Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 12/20] NFSv4.1: Ensure we call FREE_STATEID if needed on close/delegreturn/locku Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 13/20] NFSv4: nfs_inode_find_delegation_state_and_recover() should check all stateids Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 14/20] NFSv4: nfs4_do_handle_exception() handle revoke/expiry of a single stateid Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 15/20] NFSv4: nfs4_handle_delegation_recall_error() handle expiration as revoke case Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 16/20] NFSv4: nfs4_handle_setlk_error() " Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 17/20] NFSv4.1: nfs4_layoutget_handle_exception handle revoked state Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 18/20] NFSv4: Pass the stateid to the exception handler in nfs4_read/write_done_cb Trond Myklebust
2016-09-15 16:45 ` [PATCH v4 19/20] NFSv4: Fix a race in nfs_inode_reclaim_delegation() Trond Myklebust
2016-09-15 16:46 ` [PATCH v4 20/20] NFSv4: Fix a race when updating an open_stateid Trond Myklebust
2016-09-15 22:17 ` kbuild test robot [this message]
2016-09-16 4:38 ` [PATCH v4 00/20] Fix delegation behaviour when server revokes some state Oleg Drokin
2016-09-16 15:36 ` Trond Myklebust
2016-09-16 21:15 ` Oleg Drokin
2016-09-16 21:21 ` Oleg Drokin
2016-09-16 21:28 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201609160640.LCbdSjO1%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=anna.schumaker@netapp.com \
--cc=green@linuxhacker.ru \
--cc=kbuild-all@01.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).