linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: trond.myklebust@primarydata.com, anna.schumaker@netapp.com,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3 0/5] add CB_NOTIFY_LOCK support to knfsd
Date: Fri, 23 Sep 2016 17:05:00 -0400	[thread overview]
Message-ID: <20160923210500.GA9998@fieldses.org> (raw)
In-Reply-To: <1474057707-31286-1-git-send-email-jlayton@redhat.com>

On Fri, Sep 16, 2016 at 04:28:22PM -0400, Jeff Layton wrote:
> v3:
> - add NFS4_OPEN_RESULT_MAY_NOTIFY_LOCK in a separate patch
> 
> v2:
> - small bugfixes
> 
> Very minor update to the patchset I sent a week or so ago. The only real
> difference from the last is to move the addition of
> NFS4_OPEN_RESULT_MAY_NOTIFY_LOCK to a separate patch.
> 
> The basic idea is to just add support for CB_NOTIFY_LOCK callbacks,
> which just tell the client that it may want to retry a lock again
> once it becomes available.
> 
> Tested in conjunction with the corresponding client-side patch
> series.

What sort of test were you doing?

Have you checked with wireshark's CB_NOTIFY_LOCK support is complete?

--b.

> 
> Jeff Layton (5):
>   nfsd: plumb in a CB_NOTIFY_LOCK operation
>   nfsd: have nfsd4_lock use blocking locks for v4.1+ locks
>   nfsd: add a LRU list for blocked locks
>   nfs: add a new NFS4_OPEN_RESULT_MAY_NOTIFY_LOCK constant
>   nfsd: set the MAY_NOTIFY_LOCK flag in OPEN replies
> 
>  fs/nfsd/netns.h           |   1 +
>  fs/nfsd/nfs4callback.c    |  57 ++++++++++++
>  fs/nfsd/nfs4state.c       | 232 ++++++++++++++++++++++++++++++++++++++++++----
>  fs/nfsd/state.h           |  21 ++++-
>  fs/nfsd/xdr4cb.h          |   9 ++
>  include/uapi/linux/nfs4.h |   5 +-
>  6 files changed, 301 insertions(+), 24 deletions(-)
> 
> -- 
> 2.7.4

  parent reply	other threads:[~2016-09-23 21:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 20:28 [PATCH v3 0/5] add CB_NOTIFY_LOCK support to knfsd Jeff Layton
2016-09-16 20:28 ` [PATCH v3 1/5] nfsd: plumb in a CB_NOTIFY_LOCK operation Jeff Layton
2016-09-16 20:28 ` [PATCH v3 2/5] nfsd: have nfsd4_lock use blocking locks for v4.1+ locks Jeff Layton
2016-09-23 21:19   ` J. Bruce Fields
2016-09-24  0:43     ` Jeff Layton
2016-09-24 15:02       ` J. Bruce Fields
2016-09-24 16:48         ` Jeff Layton
2016-09-16 20:28 ` [PATCH v3 3/5] nfsd: add a LRU list for blocked locks Jeff Layton
2016-09-16 20:28 ` [PATCH v3 4/5] nfs: add a new NFS4_OPEN_RESULT_MAY_NOTIFY_LOCK constant Jeff Layton
2016-09-16 20:28 ` [PATCH v3 5/5] nfsd: set the MAY_NOTIFY_LOCK flag in OPEN replies Jeff Layton
2016-09-23 21:05 ` J. Bruce Fields [this message]
2016-09-24  0:48   ` [PATCH v3 0/5] add CB_NOTIFY_LOCK support to knfsd Jeff Layton
2016-09-26 16:03     ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160923210500.GA9998@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=anna.schumaker@netapp.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).