From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-nfs@vger.kernel.org
Subject: Re: sg_set_buf
Date: Thu, 20 Oct 2016 09:20:30 -0400 [thread overview]
Message-ID: <20161020132030.GA2868@fieldses.org> (raw)
In-Reply-To: <20161020102200.GA6628@infradead.org>
On Thu, Oct 20, 2016 at 03:22:00AM -0700, Christoph Hellwig wrote:
> On Tue, Oct 18, 2016 at 05:37:55PM -0400, J. Bruce Fields wrote:
> > The NFS code is using sg_set_buf to turn a bit of stack menory into a
> > scatterlist it can pass to the crypto code. That started BUG()ing as of
> > ac4e97abce9b "scatterlist: sg_set_buf() argument must be in linear
> > mapping".
> >
> > Is that BUG() being overly strict, or is this something we should never
> > have been doing in the first place?
>
> In general we use scatterlists to pass dma addresses to hardware, so
> yes, they should not point to the stack.
The crypto code isn't actually doing that though, is it?
(Or is there a chance it could be passing the data to separate crypto
hardware? Do people do that these days?)
--b.
next prev parent reply other threads:[~2016-10-20 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 21:37 sg_set_buf J. Bruce Fields
2016-10-20 10:22 ` sg_set_buf Christoph Hellwig
2016-10-20 13:20 ` J. Bruce Fields [this message]
2016-10-20 13:31 ` sg_set_buf Christoph Hellwig
2016-10-20 21:42 ` sg_set_buf J. Bruce Fields
2016-10-21 12:26 ` sg_set_buf Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020132030.GA2868@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).