From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jlayton@redhat.com>
Cc: bfields@fieldses.org, hch@lst.de, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: fix error handling for clients that fail to return the layout
Date: Fri, 21 Oct 2016 14:17:59 +0200 [thread overview]
Message-ID: <20161021121759.GA17325@lst.de> (raw)
In-Reply-To: <1476980494-2984-1-git-send-email-jlayton@redhat.com>
On Thu, Oct 20, 2016 at 12:21:34PM -0400, Jeff Layton wrote:
> Currently, when the client continually returns NFS4ERR_DELAY on a
> CB_LAYOUTRECALL, we'll give up trying to retransmit after two lease
> periods, but leave the layout in place.
>
> What we really need to do here is fence the client in this case. Have it
> fall through to that code in that case instead of into the
> NFS4ERR_NOMATCHING_LAYOUT case.
Agreed. Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-10-21 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 16:21 [PATCH] nfsd: fix error handling for clients that fail to return the layout Jeff Layton
2016-10-21 12:17 ` Christoph Hellwig [this message]
2016-10-28 20:54 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021121759.GA17325@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).