From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Trond Myklebust <trondmy@primarydata.com>
Cc: Schumaker Anna <anna.schumaker@netapp.com>,
List Linux NFS Mailing <linux-nfs@vger.kernel.org>,
List Linux Kernel Mailing <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH v3] NFSv4: replace seqcount_t with a rw_semaphore
Date: Wed, 2 Nov 2016 18:11:49 +0100 [thread overview]
Message-ID: <20161102171149.kl66dlmlrc44zock@linutronix.de> (raw)
In-Reply-To: <40147FA4-9FD8-4349-B309-751DFCE875A2@primarydata.com>
On 2016-10-31 16:11:02 [+0000], Trond Myklebust wrote:
>
> Yes, and yes. We can’t rely on the list pointers remaining correct, so we restart the list scan and we use the ops->state_flag_bit to signal whether or not state has been recovered for the entry being scanned.
but this is tested at the top of the loop and by then you look at
lists' ->next pointer which might be invalid.
Sebastian
next prev parent reply other threads:[~2016-11-02 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 16:47 [RFC PATCH] NFSv4: replace seqcount_t with a seqlock_t Sebastian Andrzej Siewior
2016-10-28 21:05 ` [PATCH v2] " Sebastian Andrzej Siewior
2016-10-28 22:24 ` Trond Myklebust
2016-10-31 10:46 ` Sebastian Andrzej Siewior
2016-10-31 13:19 ` [PATCH v3] NFSv4: replace seqcount_t with a rw_semaphore Sebastian Andrzej Siewior
2016-10-31 15:30 ` Trond Myklebust
2016-10-31 15:56 ` Sebastian Andrzej Siewior
2016-10-31 16:11 ` Trond Myklebust
2016-11-02 17:11 ` Sebastian Andrzej Siewior [this message]
2016-11-02 17:37 ` Trond Myklebust
2016-11-02 17:15 ` [PATCH v4] NFSv4: replace seqcount_t with a seqlock_t Sebastian Andrzej Siewior
[not found] ` <20161025065239.GC3341@yexl-desktop>
2016-10-28 21:08 ` [lkp] [NFSv4] 931437ee2c: BUG: sleeping function called from invalid context at mm/slab.h:393 Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102171149.kl66dlmlrc44zock@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anna.schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).