From: Chuck Lever <chuck.lever@oracle.com>
To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v2 06/12] xprtrdma: Avoid calls to ro_unmap_safe()
Date: Fri, 18 Nov 2016 09:59:44 -0500 [thread overview]
Message-ID: <20161118145944.10592.47236.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20161118145547.10592.66470.stgit@manet.1015granger.net>
Micro-optimization: Most of the time, calls to ro_unmap_safe are
expensive no-ops. Call only when there is work to do.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
net/sunrpc/xprtrdma/transport.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
index ed5e285..545d3fc 100644
--- a/net/sunrpc/xprtrdma/transport.c
+++ b/net/sunrpc/xprtrdma/transport.c
@@ -621,7 +621,8 @@
dprintk("RPC: %s: called on 0x%p\n", __func__, req->rl_reply);
- ia->ri_ops->ro_unmap_safe(r_xprt, req, !RPC_IS_ASYNC(task));
+ if (unlikely(!list_empty(&req->rl_registered)))
+ ia->ri_ops->ro_unmap_safe(r_xprt, req, !RPC_IS_ASYNC(task));
rpcrdma_unmap_sges(ia, req);
rpcrdma_buffer_put(req);
}
@@ -657,7 +658,8 @@
int rc = 0;
/* On retransmit, remove any previously registered chunks */
- r_xprt->rx_ia.ri_ops->ro_unmap_safe(r_xprt, req, false);
+ if (unlikely(!list_empty(&req->rl_registered)))
+ r_xprt->rx_ia.ri_ops->ro_unmap_safe(r_xprt, req, false);
rc = rpcrdma_marshal_req(rqst);
if (rc < 0)
next prev parent reply other threads:[~2016-11-18 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 14:58 [PATCH v2 00/12] client-side NFS/RDMA patches proposed for v4.10 Chuck Lever
2016-11-18 14:59 ` [PATCH v2 01/12] xprtrdma: Cap size of callback buffer resources Chuck Lever
2016-11-18 14:59 ` [PATCH v2 02/12] xprtrdma: Make FRWR send queue entry accounting more accurate Chuck Lever
2016-11-18 14:59 ` [PATCH v2 03/12] xprtrdma: Support for SG_GAP devices Chuck Lever
2016-11-18 14:59 ` [PATCH v2 04/12] SUNRPC: Proper metric accounting when RPC is not transmitted Chuck Lever
2016-11-18 14:59 ` [PATCH v2 05/12] xprtrdma: Address coverity complaint about wait_for_completion() Chuck Lever
2016-11-18 14:59 ` Chuck Lever [this message]
2016-11-18 14:59 ` [PATCH v2 07/12] xprtrdma: Refactor FRMR invalidation Chuck Lever
2016-11-18 15:00 ` [PATCH v2 08/12] xprtrdma: Update documenting comment Chuck Lever
2016-11-18 15:00 ` [PATCH v2 09/12] xprtrdma: Squelch "max send, max recv" messages at connect time Chuck Lever
2016-11-18 15:00 ` [PATCH v2 10/12] xprtrdma: Shorten QP access error message Chuck Lever
2016-11-18 15:00 ` [PATCH v2 11/12] xprtrdma: Update dprintk in rpcrdma_count_chunks Chuck Lever
2016-11-18 15:00 ` [PATCH v2 12/12] xprtrdma: Relocate connection helper functions Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118145944.10592.47236.stgit@manet.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).