From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Anna Schumaker <Anna.Schumaker@Netapp.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Christoph Hellwig <hch@infradead.org>,
fstests@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Add copy_file_range() tests
Date: Tue, 29 Nov 2016 15:21:46 -0800 [thread overview]
Message-ID: <20161129232146.GA25841@birch.djwong.org> (raw)
In-Reply-To: <ce1c4ee0-eaa9-1011-857a-c4930bb12115@Netapp.com>
On Tue, Nov 29, 2016 at 03:59:29PM -0500, Anna Schumaker wrote:
> Sorry for the delay! I've been busy looking at other things and
> forgot to update the copy_file_range() stuff :(
While you're at it, please make a test to check the return value for
invalid inputs. I'd prefer we avoid repeating what happened with the
vfs dedupe ioctl.
--D
>
> On 11/29/2016 03:47 PM, J. Bruce Fields wrote:
> > On Fri, Nov 25, 2016 at 12:05:10AM -0800, Christoph Hellwig wrote:
> >> On Wed, Oct 26, 2016 at 01:26:38AM -0700, Christoph Hellwig wrote:
> >>> On Wed, Sep 07, 2016 at 03:56:15PM -0400, Anna Schumaker wrote:
> >>>> These tests exercise the copy_file_range() system call, and check copying
> >>>> data to both a new file and overwriting data inside an existing file. I use
> >>>> the xfs_io "copy_range" command for the actual copies, so running these
> >>>> tests requires an up-to-date version of xfsprogs.
> >>>
> >>> Hi Anna,
> >>>
> >>> what's the status of these tests? Did you get a chance to look
> >>> into xfs_io copyfile support?
>
> xfs_io has support for copying now, so I'll make sure that the tests
> use that correctly. I promise to send out an update this week, once I
> check that everything still works!
>
> Thanks for the reminders,
> Anna
>
> >>
> >> Another month, another ping - it would be really sad to not have any
> >> real testing for copy_file_range.
> >
> > Agreed, Anna, are you still planning on doing this?
> >
> > --b.
> >
> >> I've been holding a pending change
> >> for it back for month now because I want to verify it more than cursory,
> >> but I guess I'll just have to send it anyway.
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-29 23:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 19:56 [PATCH v2 0/4] Add copy_file_range() tests Anna Schumaker
2016-09-07 19:56 ` [PATCH v2 1/4] generic/377: Add copy to new file test Anna Schumaker
2016-09-09 6:21 ` Eryu Guan
2016-09-09 6:29 ` Darrick J. Wong
2016-09-09 7:01 ` Eryu Guan
2016-09-11 23:10 ` Dave Chinner
2016-09-07 19:56 ` [PATCH v2 2/4] generic/378: Add small copies " Anna Schumaker
2016-09-07 19:56 ` [PATCH v2 3/4] generic/379: Add copy test that overwrites data Anna Schumaker
2016-09-07 19:56 ` [PATCH v2 4/4] generic/380: Add a copy test for overwriting small amounts of data Anna Schumaker
2016-09-17 17:03 ` [PATCH v2 0/4] Add copy_file_range() tests Darrick J. Wong
2016-10-26 8:26 ` Christoph Hellwig
2016-11-25 8:05 ` Christoph Hellwig
2016-11-29 20:47 ` J. Bruce Fields
2016-11-29 20:59 ` Anna Schumaker
2016-11-29 23:21 ` Darrick J. Wong [this message]
2016-12-02 20:00 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129232146.GA25841@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=bfields@fieldses.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).