From: Christoph Hellwig <hch@infradead.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Steve Dickson <SteveD@redhat.com>
Subject: Re: [PATCH] NFSD: only support readonly export for !fsync and readonly filesystem
Date: Sun, 8 Jan 2017 02:07:15 -0800 [thread overview]
Message-ID: <20170108100715.GC25268@infradead.org> (raw)
In-Reply-To: <960d206f-3cb5-b60e-5245-d7282dabf664@gmail.com>
On Sat, Dec 31, 2016 at 09:18:08PM +0800, Kinglong Mee wrote:
> Commit fae5096ad217
> "nfsd: assume writeable exportabled filesystems have f_sync"
> have remove the checking of f_sync.
>
> Christoph Hellwig suggests,
> "Warn and refuse the writable export."
>
> I think just covert to a readonly export for !fsync filesystem,
> also, for a readonly filesystem is reasonable.
I don't like degrading the export. We should require an explicit
ro option in this case.
next prev parent reply other threads:[~2017-01-08 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 13:18 [PATCH] NFSD: only support readonly export for !fsync and readonly filesystem Kinglong Mee
2017-01-04 17:29 ` J. Bruce Fields
2017-01-05 14:20 ` Kinglong Mee
2017-01-05 14:46 ` [PATCH v2] NFSD: Only " Kinglong Mee
2017-01-08 10:07 ` Christoph Hellwig [this message]
2017-01-08 12:43 ` [PATCH] NFSD: only " Kinglong Mee
2017-01-12 21:18 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108100715.GC25268@infradead.org \
--to=hch@infradead.org \
--cc=SteveD@redhat.com \
--cc=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).