From: Yuval Shaia <yuval.shaia@oracle.com>
To: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] svcrdma: avoid duplicate dma unmapping during error recovery
Date: Mon, 9 Jan 2017 08:42:25 +0200 [thread overview]
Message-ID: <20170109064224.GA3820@yuval-lap> (raw)
In-Reply-To: <20170109103044.5590-1-sriharsha.basavapatna@broadcom.com>
On Mon, Jan 09, 2017 at 04:00:44PM +0530, Sriharsha Basavapatna wrote:
> In rdma_read_chunk_frmr() when ib_post_send() fails, the error code path
> invokes ib_dma_unmap_sg() to unmap the sg list. It then invokes
> svc_rdma_put_frmr() which in turn tries to unmap the same sg list through
> ib_dma_unmap_sg() again. This second unmap is invalid and could lead to
> problems when the iova being unmapped is subsequently reused. Remove
> the call to unmap in rdma_read_chunk_frmr() and let svc_rdma_put_frmr()
> handle it.
>
> Fixes: 412a15c0fe53 ("svcrdma: Port to new memory registration API")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> index 57d35fbb1c28..172b537f8cfc 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> @@ -347,8 +347,6 @@ int rdma_read_chunk_frmr(struct svcxprt_rdma *xprt,
> atomic_inc(&rdma_stat_read);
> return ret;
> err:
> - ib_dma_unmap_sg(xprt->sc_cm_id->device,
> - frmr->sg, frmr->sg_nents, frmr->direction);
> svc_rdma_put_context(ctxt, 0);
> svc_rdma_put_frmr(xprt, frmr);
> return ret;
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> --
> 2.11.0.258.ge05806da9
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-09 6:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 10:30 [PATCH] svcrdma: avoid duplicate dma unmapping during error recovery Sriharsha Basavapatna
2017-01-09 6:42 ` Yuval Shaia [this message]
2017-01-09 15:05 ` Chuck Lever
2017-01-12 21:15 ` J. Bruce Fields
-- strict thread matches above, loose matches on Subject: below --
2017-01-04 16:03 Sriharsha Basavapatna
2017-01-04 18:20 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109064224.GA3820@yuval-lap \
--to=yuval.shaia@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).