From: bfields@fieldses.org (J. Bruce Fields)
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>,
Matthieu Herrb <matthieu.herrb@laas.fr>
Subject: Re: [PATCH] NFSv4.2: Fix file creating with O_EXCL get a bad mode
Date: Thu, 12 Jan 2017 15:47:22 -0500 [thread overview]
Message-ID: <20170112204722.GC10501@fieldses.org> (raw)
In-Reply-To: <a76cec59-f007-5c26-dc26-4cc8a6e4daef@gmail.com>
On Sat, Jan 07, 2017 at 10:45:47PM +0800, Kinglong Mee wrote:
> Acorrding to Matthieu Herrb's test cases, a new created file will
> get a bad mode as 0666 (expected 0644) after commit dff25ddb4808
> "nfs: add support for the umask attribute".
>
> It is caused by missing check of FATTR4_WORD2_MODE_UMASK
> in nfs4_exclusive_attrset.
I don't understand:
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 6dcbc5d..a3e9ef1 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -2697,7 +2697,8 @@ static inline void nfs4_exclusive_attrset(struct nfs4_opendata *opendata,
> sattr->ia_valid |= ATTR_MTIME;
>
> /* Except MODE, it seems harmless of setting twice. */
> - if ((attrset[1] & FATTR4_WORD1_MODE))
> + if ((attrset[1] & FATTR4_WORD1_MODE) ||
> + (attrset[2] & FATTR4_WORD2_MODE_UMASK))
> sattr->ia_valid &= ~ATTR_MODE;
If I'm understanding this function correctly, attrset is the set of
attributes which the server tells us were used to store the verifier.
But mode_umask would never be a sensible place to store the
verifier, so if the server's response really says that then something's
wrong.
We should probably look at a network trace.
--b.
>
> if (attrset[2] & FATTR4_WORD2_SECURITY_LABEL)
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-12 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 14:45 [PATCH] NFSv4.2: Fix file creating with O_EXCL get a bad mode Kinglong Mee
2017-01-12 20:47 ` J. Bruce Fields [this message]
2017-01-15 7:55 ` Kinglong Mee
2017-01-16 17:03 ` Matthieu Herrb
2017-01-18 5:56 ` Kinglong Mee
2017-03-03 13:32 ` Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112204722.GC10501@fieldses.org \
--to=bfields@fieldses.org \
--cc=agruenba@redhat.com \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=matthieu.herrb@laas.fr \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).