From: bfields@fieldses.org (J. Bruce Fields)
To: Christoph Hellwig <hch@lst.de>
Cc: bfields@redhat.com, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: setattr ATTR_SIZE vs the rest
Date: Mon, 23 Jan 2017 11:58:33 -0500 [thread overview]
Message-ID: <20170123165833.GD9493@fieldses.org> (raw)
In-Reply-To: <1485104060-15209-1-git-send-email-hch@lst.de>
On Sun, Jan 22, 2017 at 05:54:19PM +0100, Christoph Hellwig wrote:
> I've got a report that there NFS clients that send SETATTR requests that
> mix size changes with uid/gid changes
That sounds a little weird. Do you know anything about which clients,
or how common the behavior is?
> (see the recent pynfs patch for an
> artifical reproducer). At least XFS and GFS2 are very unhappy with this,
> and other file systems also don't seem to handle the case correctly.
Does this cause a crash or corruption, or "just" fail to set the
attributes correctly? (Just wondering how urgent the fix is....).
--b.
>
> This patch splits the truncate processing in NFS out into a separate
> ->setattr call and uses the vfs_truncate helper for it, which also happens
> to shrink the NFSD code size by reusing more VFS boiler plate code.
>
> I suspect in the mid-term we really should add a ->truncate method (different
> from the previous callback of the same name) to separate the two concepts
> clearly at the VFS level.
next prev parent reply other threads:[~2017-01-23 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 16:54 setattr ATTR_SIZE vs the rest Christoph Hellwig
2017-01-22 16:54 ` [PATCH] nfsd: special case truncates some more Christoph Hellwig
2017-01-23 12:21 ` Jeff Layton
2017-01-23 12:33 ` Christoph Hellwig
2017-01-23 15:36 ` Christoph Hellwig
2017-01-23 15:52 ` Jeff Layton
2017-01-23 16:05 ` Christoph Hellwig
2017-01-23 16:14 ` Jeff Layton
2017-01-23 16:20 ` Trond Myklebust
2017-01-23 16:26 ` hch
2017-01-23 17:25 ` Trond Myklebust
2017-01-23 17:38 ` hch
2017-01-23 17:42 ` Trond Myklebust
2017-01-24 16:25 ` J. Bruce Fields
2017-01-24 22:02 ` J. Bruce Fields
2017-01-23 16:58 ` J. Bruce Fields [this message]
2017-01-24 7:52 ` setattr ATTR_SIZE vs the rest Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123165833.GD9493@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).