linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lennart Poettering <lennart@poettering.net>
To: NeilBrown <neilb@suse.com>
Cc: systemd-devel@freedesktop.org,
	List Linux NFS Mailing <linux-nfs@vger.kernel.org>
Subject: Re: [systemd-devel] RequiresMountsFor and the noauto option.
Date: Mon, 6 Feb 2017 21:38:13 +0100	[thread overview]
Message-ID: <20170206203813.GA20905@gardel-login> (raw)
In-Reply-To: <87inp6eipr.fsf@notabene.neil.brown.name>

On Mon, 23.01.17 11:13, NeilBrown (neilb@suse.com) wrote:

> 
> hi,
>  according to "man systemd.unit" :
> 
>        RequiresMountsFor=
>            Takes a space-separated list of absolute paths.
>            Automatically adds dependencies of type Requires= and
>            After= for all mount units required to access the
>            specified path.
> 
>            Mount points marked with noauto are not mounted
>            automatically and will be ignored for the purposes of
>            this option. If such a mount should be a requirement for
>            this unit, direct dependencies on the mount units may be
>            added (Requires= and After= or some other combination).

Hmm, this is weird. This is actually not what happens. The
documentaiton is simply not correct here. That's a bug we need to
fix. I filed a bug about this now:

https://github.com/systemd/systemd/issues/5249

What actually happens is that RMF= adds After= for all prefix mount
units, but Requires= only to those which have a fragment file
(i.e. are explicitly configured). The "noauto" flag is not checked.

Sorry for the confusion.

>  If the documentation is wrong, and the code is correct, would it be
>  possible to get "AfterMountsFor=" as that is the functionality that I
>  really want.

I figure we could add that. Please file an RFE on github.

Lennart

-- 
Lennart Poettering, Red Hat

      parent reply	other threads:[~2017-02-06 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23  0:13 RequiresMountsFor and the noauto option NeilBrown
2017-01-23  4:10 ` [systemd-devel] " Andrei Borzenkov
2017-01-23  5:18   ` NeilBrown
2017-02-06 20:38 ` Lennart Poettering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206203813.GA20905@gardel-login \
    --to=lennart@poettering.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=systemd-devel@freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).