From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: don't get write access twіce in nfsd_setattr
Date: Wed, 8 Feb 2017 16:51:01 -0500 [thread overview]
Message-ID: <20170208215101.GC17622@fieldses.org> (raw)
In-Reply-To: <20170208215038.GA21910@lst.de>
On Wed, Feb 08, 2017 at 10:50:38PM +0100, Christoph Hellwig wrote:
> On Wed, Feb 08, 2017 at 04:45:38PM -0500, J. Bruce Fields wrote:
> > On Tue, Feb 07, 2017 at 10:12:44AM +0100, Christoph Hellwig wrote:
> > > Turns out doing mnt_want_write twice for the same process makes
> > > lockdep unhappy, so move the fh_want_write down to after calling
> > > vfs_truncate in nfsd_setattr. No changes to error handling required
> > > as the want write state is automatically cleaned up by the caller
> > > based on a flag in the svc_fh.
> > >
> > > Fixes: 41f53350 ("nfsd: special case truncates some more")
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > Reported-by: Dave Jones <davej@codemonkey.org.uk>
> >
> > Thanks, I'll see if I can squeeze this into 4.10.--b.
>
> FYI, Chuck just reported another issue, let's wait for that for now.
OK.--b.
next prev parent reply other threads:[~2017-02-08 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 9:12 [PATCH] nfsd: don't get write access twіce in nfsd_setattr Christoph Hellwig
2017-02-08 21:45 ` J. Bruce Fields
2017-02-08 21:50 ` Christoph Hellwig
2017-02-08 21:51 ` J. Bruce Fields [this message]
2017-02-09 13:25 ` Christoph Hellwig
2017-02-09 15:43 ` J. Bruce Fields
2017-02-09 15:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208215101.GC17622@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).