From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Olga Kornievskaia <kolga@netapp.com>,
Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [RFC v1 01/19] fs: Don't copy beyond the end of the file
Date: Tue, 7 Mar 2017 15:40:51 -0800 [thread overview]
Message-ID: <20170307234051.GA29977@infradead.org> (raw)
In-Reply-To: <20170303204747.GE13877@fieldses.org>
On Fri, Mar 03, 2017 at 03:47:47PM -0500, J. Bruce Fields wrote:
> That's what I think too, but then is COPY(2) wrong?:
Either the current kernel code or the man page is wrong..
> Also, copy_file_range can be implemented by ->clone_file_range, where
> these kinds of checks make more sense, I think; e.g. from btrfs:
>
> ret = -EINVAL;
> if (off + len > src->i_size || off + len < off)
> goto out_unlock;
>
> Well, so the caller just has to be prepared for either behavior, I
> guess, but that may make it more complicated to use.
We'll need to stick to one behavior. So between the man page and
the clone implementation I guess this patch is fine after all.
next prev parent reply other threads:[~2017-03-08 0:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:01 [RFC v1 00/19] NFS support for inter and async COPY Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 01/19] fs: Don't copy beyond the end of the file Olga Kornievskaia
2017-03-02 16:22 ` Christoph Hellwig
2017-03-02 16:34 ` Olga Kornievskaia
2017-03-03 20:47 ` J. Bruce Fields
2017-03-03 21:08 ` Olga Kornievskaia
2017-03-03 21:32 ` J. Bruce Fields
[not found] ` <B3F80DA0-B4F8-4628-88C5-E5C047620F17@netapp.com>
2017-03-04 2:10 ` J. Bruce Fields
2017-03-06 16:27 ` [RFC v1 01/19] " Olga Kornievskaia
2017-03-06 19:09 ` J. Bruce Fields
2017-03-06 19:23 ` J. Bruce Fields
2017-03-07 14:18 ` Olga Kornievskaia
2017-03-07 23:40 ` Christoph Hellwig [this message]
2017-03-08 17:05 ` [RFC v1 01/19] fs: " J. Bruce Fields
2017-03-08 17:25 ` Christoph Hellwig
2017-03-08 17:32 ` Olga Kornievskaia
2017-03-08 19:53 ` J. Bruce Fields
2017-03-08 20:00 ` Olga Kornievskaia
2017-03-08 20:18 ` J. Bruce Fields
2017-03-08 20:18 ` Trond Myklebust
2017-03-08 20:32 ` bfields
2017-03-08 20:49 ` Trond Myklebust
2017-03-09 15:29 ` bfields
2017-03-09 15:35 ` hch
2017-03-09 16:16 ` bfields
2017-03-09 16:17 ` hch
2017-03-09 17:28 ` Olga Kornievskaia
2017-03-09 18:40 ` bfields
2017-03-09 21:55 ` hch
2017-03-09 17:35 ` Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 02/19] VFS permit cross device vfs_copy_file_range Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 03/19] VFS don't try clone if superblocks are different Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 04/19] NFS inter ssc open Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 05/19] NFS add COPY_NOTIFY operation Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 06/19] NFS add ca_source_server<> to COPY Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 07/19] NFS CB_OFFLOAD xdr Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 08/19] NFS OFFLOAD_STATUS xdr Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 09/19] NFS OFFLOAD_STATUS op Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 10/19] NFS OFFLOAD_CANCEL xdr Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 11/19] NFS COPY xdr handle async reply Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 12/19] NFS add support for asynchronous COPY Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 13/19] NFS handle COPY reply CB_OFFLOAD call race Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 14/19] NFS send OFFLOAD_CANCEL when COPY killed Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 15/19] NFS make COPY synchronous xdr configurable Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 16/19] NFS handle COPY ERR_OFFLOAD_NO_REQS Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 17/19] NFS skip recovery of copy open on dest server Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 18/19] NFS recover from destination server reboot for copies Olga Kornievskaia
2017-03-02 16:01 ` [RFC v1 19/19] NFS if we got partial copy ignore errors Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307234051.GA29977@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@primarydata.com \
--cc=bfields@fieldses.org \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).