From: Eryu Guan <eguan@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
Anna Schumaker <Anna.Schumaker@Netapp.com>
Cc: fstests@vger.kernel.org, linux-nfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH v5 0/5] Add copy_file_range() tests
Date: Mon, 20 Mar 2017 13:24:57 +0800 [thread overview]
Message-ID: <20170320052457.GH14226@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170317220246.GA12585@birch.djwong.org>
On Fri, Mar 17, 2017 at 03:02:46PM -0700, Darrick J. Wong wrote:
> On Fri, Mar 17, 2017 at 03:52:28PM -0400, Anna Schumaker wrote:
> > These tests exercise the copy_file_range() system call, and check copying
> > data to both a new file and overwriting data inside an existing file.
> >
> > Sorry it took so long to get this version out. I forgot about these patches
> > after the last submission.
>
> Hooray, tests finally!
>
> I had to bump the numbers up due to conflicts (it's usually best to pick
> a really high number and let Eryu mvtest them to their real numbers),
> but these mostly look ok.
Usually the test numbers are not a problem, as long as the patchset is
based on latest master and there's no test number conflicts :)
Overall the tests look fine to me too.
>
> However, I do see that something isn't triggering an EINVAL return code:
Same results here, tested with xfs/ext4/btrfs on 4.11-rc2 kernel.
And another nitpick is the year in copyright, s/2016/2017/ ?
Thanks,
Eryu
next prev parent reply other threads:[~2017-03-20 5:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 19:52 [PATCH v5 0/5] Add copy_file_range() tests Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 1/5] generic/416: Add copy to new file test Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 2/5] generic/417: Add small copies " Anna Schumaker
2017-03-22 16:45 ` Boaz Harrosh
2017-03-17 19:52 ` [PATCH v5 3/5] generic/418: Add copy test that overwrites data Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 4/5] generic/419: Add a copy test for overwriting small amounts of data Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 5/5] generic/420: Add a copy test for invalid input Anna Schumaker
2017-03-17 22:02 ` [PATCH v5 0/5] Add copy_file_range() tests Darrick J. Wong
2017-03-20 5:24 ` Eryu Guan [this message]
2017-05-02 22:16 ` Darrick J. Wong
2017-05-03 12:56 ` Olga Kornievskaia
2017-05-03 15:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320052457.GH14226@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).