From: Chuck Lever <chuck.lever@oracle.com>
To: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: [PATCH] svcrdma: set XPT_CONG_CTRL flag for bc xprt
Date: Sun, 26 Mar 2017 19:27:35 -0400 [thread overview]
Message-ID: <20170326231254.1319.26075.stgit@manet.1015granger.net> (raw)
Same change as Kinglong Mee's fix for the TCP backchannel service.
Fixes: 5283b03ee5cd ("nfs/nfsd/sunrpc: enforce transport...")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
Some (perhaps late) review comments on 5283b03ee5cd:
I have reservations about returning RPC_PROG_MISMATCH in this case.
RPC_PROG_UNAVAIL is more sensible. But the use of UDP with NFSv4 is
not an RPC-level error, thus reporting the problem here seems like a
layering violation.
I'm not sure why an explicit check is needed: if the server isn't
listening on UDP, wouldn't clients see a transport-level rejection
(like ECONNREFUSED)?
Are we certain that all client implementations (including
backchannel clients) will do something useful when presented with
such a rejection? At least in the backchannel case, the Linux server
had no idea what to do with RPC_PROG_MISMATCH on the backchannel.
The workload stopped dead, no error report anywhere.
net/sunrpc/xprtrdma/svc_rdma_transport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index c13a5c3..fc8f14c 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -127,6 +127,7 @@ static struct svc_xprt *svc_rdma_bc_create(struct svc_serv *serv,
xprt = &cma_xprt->sc_xprt;
svc_xprt_init(net, &svc_rdma_bc_class, xprt, serv);
+ set_bit(XPT_CONG_CTRL, &xprt->xpt_flags);
serv->sv_bc_xprt = xprt;
dprintk("svcrdma: %s(%p)\n", __func__, xprt);
next reply other threads:[~2017-03-26 23:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 23:27 Chuck Lever [this message]
2017-03-27 1:21 ` [PATCH] svcrdma: set XPT_CONG_CTRL flag for bc xprt Jeff Layton
2017-03-27 2:38 ` Chuck Lever
2017-03-27 2:41 ` Chuck Lever
2017-03-27 11:07 ` Jeff Layton
2017-03-27 12:39 ` Jeff Layton
2017-03-29 1:16 ` J. Bruce Fields
2017-03-29 11:01 ` Jeff Layton
2017-03-29 1:22 ` J. Bruce Fields
2017-03-29 11:02 ` Jeff Layton
2017-03-29 1:27 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326231254.1319.26075.stgit@manet.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).