From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 01/13] svcrdma: Move send_wr to svc_rdma_op_ctxt
Date: Thu, 30 Mar 2017 05:06:39 -0700 [thread overview]
Message-ID: <20170330120639.GA31144@infradead.org> (raw)
In-Reply-To: <20170327134802.5585.70150.stgit@klimt.1015granger.net>
> + svc_rdma_build_send_wr(ctxt, sge_no);
> + send_wr = &ctxt->send_wr;
> + if (inv_rkey) {
> + send_wr->opcode = IB_WR_SEND_WITH_INV;
> + send_wr->ex.invalidate_rkey = inv_rkey;
> + }
Seems a bit odd to overwrite the work that svc_rdma_build_send_wr in
the caller. I would propbably add this work to svc_rdma_build_send_wr.
Also any reason svc_rdma_build_send_wr can't call svc_rdma_send
directly (although it would probably need a new name then)?
next prev parent reply other threads:[~2017-03-30 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 13:47 [PATCH v2 00/13] Server-side NFS/RDMA changes proposed for v4.12 Chuck Lever
2017-03-27 13:48 ` [PATCH v2 01/13] svcrdma: Move send_wr to svc_rdma_op_ctxt Chuck Lever
2017-03-30 12:06 ` Christoph Hellwig [this message]
2017-03-27 13:48 ` [PATCH v2 02/13] svcrdma: Add svc_rdma_map_reply_hdr() Chuck Lever
2017-03-30 12:07 ` Christoph Hellwig
2017-03-27 13:48 ` [PATCH v2 03/13] svcrdma: Eliminate RPCRDMA_SQ_DEPTH_MULT Chuck Lever
2017-03-30 12:07 ` Christoph Hellwig
2017-03-27 13:48 ` [PATCH v2 04/13] svcrdma: Add helper to save pages under I/O Chuck Lever
2017-03-30 12:08 ` Christoph Hellwig
2017-03-27 13:48 ` [PATCH v2 05/13] svcrdma: Introduce local rdma_rw API helpers Chuck Lever
2017-03-30 12:30 ` Christoph Hellwig
2017-03-30 15:29 ` Chuck Lever
2017-03-27 13:48 ` [PATCH v2 06/13] svcrdma: Use rdma_rw API in RPC reply path Chuck Lever
2017-03-27 13:48 ` [PATCH v2 07/13] svcrdma: Clean up RDMA_ERROR path Chuck Lever
2017-03-27 13:48 ` [PATCH v2 08/13] svcrdma: Report Write/Reply chunk overruns Chuck Lever
2017-03-27 13:49 ` [PATCH v2 09/13] svcrdma: Clean up RPC-over-RDMA backchannel reply processing Chuck Lever
2017-03-27 13:49 ` [PATCH v2 10/13] svcrdma: Reduce size of sge array in struct svc_rdma_op_ctxt Chuck Lever
2017-03-27 13:49 ` [PATCH v2 11/13] svcrdma: Remove unused RDMA Write completion handler Chuck Lever
2017-03-27 13:49 ` [PATCH v2 12/13] svcrdma: Remove the req_map cache Chuck Lever
2017-03-27 13:49 ` [PATCH v2 13/13] svcrdma: Clean out old XDR encoders Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330120639.GA31144@infradead.org \
--to=hch@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).