From: kbuild test robot <lkp@intel.com>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: kbuild-all@01.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Jeff Layton <jlayton@poochiereds.net>,
bfields@fieldses.org, Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/6] locks: Set FL_CLOSE when removing flock locks on close()
Date: Sat, 8 Apr 2017 13:34:18 +0800 [thread overview]
Message-ID: <201704081358.uVMczTII%fengguang.wu@intel.com> (raw)
In-Reply-To: <d27daedb9fd68b23e25bc63f2852f25a803cdefb.1491477181.git.bcodding@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 5473 bytes --]
Hi Benjamin,
[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v4.11-rc5 next-20170407]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Benjamin-Coddington/Skipped-unlocks/20170407-045120
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: x86_64-randconfig-n0-04081158 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
fs/fuse/file.c: In function 'fuse_setlk':
fs/fuse/file.c:2171:2: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
if (fl->fl_flags & FL_CLOSE_POSIX == FL_CLOSE_POSIX)
^
fs/fuse/file.c:2171:2: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/uapi/linux/fuse.h:121,
from fs/fuse/fuse_i.h:12,
from fs/fuse/file.c:9:
>> include/linux/compiler.h:163:17: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
static struct ftrace_branch_data \
^
include/linux/compiler.h:158:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^
fs/fuse/file.c:2171:2: note: in expansion of macro 'if'
if (fl->fl_flags & FL_CLOSE_POSIX == FL_CLOSE_POSIX)
^
--
fs//fuse/file.c: In function 'fuse_setlk':
fs//fuse/file.c:2171:2: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
if (fl->fl_flags & FL_CLOSE_POSIX == FL_CLOSE_POSIX)
^
fs//fuse/file.c:2171:2: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/uapi/linux/fuse.h:121,
from fs//fuse/fuse_i.h:12,
from fs//fuse/file.c:9:
>> include/linux/compiler.h:163:17: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
static struct ftrace_branch_data \
^
include/linux/compiler.h:158:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^
fs//fuse/file.c:2171:2: note: in expansion of macro 'if'
if (fl->fl_flags & FL_CLOSE_POSIX == FL_CLOSE_POSIX)
^
vim +163 include/linux/compiler.h
d45ae1f7 Steven Rostedt (VMware 2017-01-17 147) # define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
1f0d69a9 Steven Rostedt 2008-11-12 148 # endif
1f0d69a9 Steven Rostedt 2008-11-12 149 # ifndef unlikely
d45ae1f7 Steven Rostedt (VMware 2017-01-17 150) # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
1f0d69a9 Steven Rostedt 2008-11-12 151 # endif
2bcd521a Steven Rostedt 2008-11-21 152
2bcd521a Steven Rostedt 2008-11-21 153 #ifdef CONFIG_PROFILE_ALL_BRANCHES
2bcd521a Steven Rostedt 2008-11-21 154 /*
2bcd521a Steven Rostedt 2008-11-21 155 * "Define 'is'", Bill Clinton
2bcd521a Steven Rostedt 2008-11-21 156 * "Define 'if'", Steven Rostedt
2bcd521a Steven Rostedt 2008-11-21 157 */
ab3c9c68 Linus Torvalds 2009-04-07 158 #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
ab3c9c68 Linus Torvalds 2009-04-07 159 #define __trace_if(cond) \
b33c8ff4 Arnd Bergmann 2016-02-12 160 if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
2bcd521a Steven Rostedt 2008-11-21 161 ({ \
2bcd521a Steven Rostedt 2008-11-21 162 int ______r; \
2bcd521a Steven Rostedt 2008-11-21 @163 static struct ftrace_branch_data \
2bcd521a Steven Rostedt 2008-11-21 164 __attribute__((__aligned__(4))) \
2bcd521a Steven Rostedt 2008-11-21 165 __attribute__((section("_ftrace_branch"))) \
2bcd521a Steven Rostedt 2008-11-21 166 ______f = { \
2bcd521a Steven Rostedt 2008-11-21 167 .func = __func__, \
2bcd521a Steven Rostedt 2008-11-21 168 .file = __FILE__, \
2bcd521a Steven Rostedt 2008-11-21 169 .line = __LINE__, \
2bcd521a Steven Rostedt 2008-11-21 170 }; \
2bcd521a Steven Rostedt 2008-11-21 171 ______r = !!(cond); \
:::::: The code at line 163 was first introduced by commit
:::::: 2bcd521a684cc94befbe2ce7d5b613c841b0d304 trace: profile all if conditionals
:::::: TO: Steven Rostedt <srostedt@redhat.com>
:::::: CC: Ingo Molnar <mingo@elte.hu>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26517 bytes --]
next prev parent reply other threads:[~2017-04-08 5:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 11:23 [PATCH v5 0/6] Skipped unlocks Benjamin Coddington
2017-04-06 11:23 ` [PATCH 1/6] NFS4: remove a redundant lock range check Benjamin Coddington
2017-04-06 11:23 ` [PATCH 2/6] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2017-04-06 11:23 ` [PATCH 3/6] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2017-04-06 18:17 ` Jeff Layton
2017-04-08 5:34 ` kbuild test robot [this message]
2017-04-06 11:23 ` [PATCH 4/6] NFS: Add an iocounter wait function for async RPC tasks Benjamin Coddington
2017-04-07 10:44 ` Jeff Layton
2017-04-07 11:26 ` Benjamin Coddington
2017-04-06 11:23 ` [PATCH 5/6] lockd: Introduce nlmclnt_operations Benjamin Coddington
2017-04-07 12:10 ` Jeff Layton
2017-04-06 11:23 ` [PATCH 6/6] NFS: Always wait for I/O completion before unlock Benjamin Coddington
2017-04-07 12:22 ` Jeff Layton
2017-04-07 13:34 ` Benjamin Coddington
-- strict thread matches above, loose matches on Subject: below --
2017-04-11 16:50 [PATCH v6 0/6] Skipped unlocks Benjamin Coddington
2017-04-11 16:50 ` [PATCH 3/6] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2017-04-01 3:15 [PATCH v4 0/6] Skipped unlocks Benjamin Coddington
2017-04-01 3:16 ` [PATCH 3/6] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2017-04-01 13:50 ` Jeff Layton
2017-04-03 9:44 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201704081358.uVMczTII%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=anna.schumaker@netapp.com \
--cc=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).