From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Olga Kornievskaia <aglo@umich.edu>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>,
Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org, linux-nfs <linux-nfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v5 0/5] Add copy_file_range() tests
Date: Wed, 3 May 2017 08:48:39 -0700 [thread overview]
Message-ID: <20170503154839.GF5975@birch.djwong.org> (raw)
In-Reply-To: <CAN-5tyGaaPrHSmxNGYWfsbxNECKE1NZz9bp4shy-kQDs2D=MrQ@mail.gmail.com>
On Wed, May 03, 2017 at 08:56:11AM -0400, Olga Kornievskaia wrote:
> On Tue, May 2, 2017 at 6:16 PM, Darrick J. Wong <darrick.wong@oracle.com> wrote:
> > On Mon, Mar 20, 2017 at 01:24:57PM +0800, Eryu Guan wrote:
> >> On Fri, Mar 17, 2017 at 03:02:46PM -0700, Darrick J. Wong wrote:
> >> > On Fri, Mar 17, 2017 at 03:52:28PM -0400, Anna Schumaker wrote:
> >> > > These tests exercise the copy_file_range() system call, and check copying
> >> > > data to both a new file and overwriting data inside an existing file.
> >> > >
> >> > > Sorry it took so long to get this version out. I forgot about these patches
> >> > > after the last submission.
> >> >
> >> > Hooray, tests finally!
> >> >
> >> > I had to bump the numbers up due to conflicts (it's usually best to pick
> >> > a really high number and let Eryu mvtest them to their real numbers),
> >> > but these mostly look ok.
> >>
> >> Usually the test numbers are not a problem, as long as the patchset is
> >> based on latest master and there's no test number conflicts :)
> >>
> >> Overall the tests look fine to me too.
> >>
> >> >
> >> > However, I do see that something isn't triggering an EINVAL return code:
> >>
> >> Same results here, tested with xfs/ext4/btrfs on 4.11-rc2 kernel.
> >>
> >> And another nitpick is the year in copyright, s/2016/2017/ ?
> >
> > Another month, another kernel release... can we please get these tests
> > fixed and integrated?
> >
>
> I'm curious when you say "testing with btrfs" does it mean NFS server
> exporting btrfs or does it mean just local btrfs?
Local btrfs, xfs, and ext4.
--D
>
> > --D
> >
> >>
> >> Thanks,
> >> Eryu
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe fstests" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-05-03 15:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 19:52 [PATCH v5 0/5] Add copy_file_range() tests Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 1/5] generic/416: Add copy to new file test Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 2/5] generic/417: Add small copies " Anna Schumaker
2017-03-22 16:45 ` Boaz Harrosh
2017-03-17 19:52 ` [PATCH v5 3/5] generic/418: Add copy test that overwrites data Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 4/5] generic/419: Add a copy test for overwriting small amounts of data Anna Schumaker
2017-03-17 19:52 ` [PATCH v5 5/5] generic/420: Add a copy test for invalid input Anna Schumaker
2017-03-17 22:02 ` [PATCH v5 0/5] Add copy_file_range() tests Darrick J. Wong
2017-03-20 5:24 ` Eryu Guan
2017-05-02 22:16 ` Darrick J. Wong
2017-05-03 12:56 ` Olga Kornievskaia
2017-05-03 15:48 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503154839.GF5975@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=Anna.Schumaker@netapp.com \
--cc=aglo@umich.edu \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).