From: Eryu Guan <eguan@redhat.com>
To: Anna Schumaker <Anna.Schumaker@Netapp.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
fstests@vger.kernel.org, linux-nfs@vger.kernel.org,
hch@infradead.org
Subject: Re: [PATCH v6 4/5] generic/432: Add a copy test for overwriting small amounts of data
Date: Thu, 11 May 2017 15:27:47 +0800 [thread overview]
Message-ID: <20170511072747.GH7250@eguan.usersys.redhat.com> (raw)
In-Reply-To: <658f2572-9767-3dd7-c48e-9cb8f2b28510@Netapp.com>
On Wed, May 10, 2017 at 02:39:46PM -0400, Anna Schumaker wrote:
>
>
> On 05/10/2017 02:37 PM, Darrick J. Wong wrote:
> > On Wed, May 10, 2017 at 01:46:27PM -0400, Anna Schumaker wrote:
> >> This test is similar to 345, except that it copies one byte at a time to
> >
> > 345? Or is that now 431? Perhaps amend the commit message to "This
> > test is similar to the previous one, except..."?
>
> Yeah, I forgot to update that :( It's supposed to be for the previous test, so that's probably the best wording to use.
I can fix it at commit time. Thanks for the tests! And thanks Darrick
for reviewing!
BTW, seq number should be dropped in summary line too, tests are always
re-numberd on commit anyway, "generic: Add copy to new file test" should
be fine :)
Thanks,
Eryu
next prev parent reply other threads:[~2017-05-11 7:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 17:46 [PATCH v6 0/5] Add copy_file_range() tests Anna Schumaker
2017-05-10 17:46 ` [PATCH v6 1/5] generic/429: Add copy to new file test Anna Schumaker
2017-05-12 13:08 ` Eryu Guan
2017-05-10 17:46 ` [PATCH v6 2/5] generic/430: Add small copies " Anna Schumaker
2017-05-10 17:46 ` [PATCH v6 3/5] generic/431: Add copy test that overwrites data Anna Schumaker
2017-05-10 17:46 ` [PATCH v6 4/5] generic/432: Add a copy test for overwriting small amounts of data Anna Schumaker
2017-05-10 18:37 ` Darrick J. Wong
2017-05-10 18:39 ` Anna Schumaker
2017-05-11 7:27 ` Eryu Guan [this message]
2017-05-10 17:46 ` [PATCH v6 5/5] generic/433: Add a copy test for invalid input Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511072747.GH7250@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).