linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org,
	Weston Andros Adamson <dros@primarydata.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [RFC PATCH] nfs: test nfs4_getfacl near page size ACL from server
Date: Thu, 25 May 2017 09:26:25 -0400	[thread overview]
Message-ID: <20170525132625.GA6658@parsley.fieldses.org> (raw)
In-Reply-To: <20170525040119.GB23805@eguan.usersys.redhat.com>

On Thu, May 25, 2017 at 12:01:19PM +0800, Eryu Guan wrote:
> Yes, that's a problem, it's been 'xfstests' for at least 14 years and
> 'fstests' is only there for 3 years, sometimes (or most of the times) we
> still call it 'xfstests' for a better understanding.

Just to troll slightly: I actually don't believe you when you say it's
been renamed.  I don't see any evidence of that.

The repository still seems to be called xfstests-dev, the README calls
it "the FSQA suite" or "xfstests", with only a brief mention of the
fstest mailing list at the end.  In fact that's the only use of the term
"fstests" in the entire repository:

	$ git grep '\<xfstests'|wc -l
	36
	$ git grep '\<fstests'|wc -l
	1

And I'm not turning up any references to fstests from google except for
references to the mailing list name.  Your email here is the only
reference I can find to the project being renamed at all.  (I do see one
mail announcing the mailist name change.)

> > Anyway, thanks for adding this.  I do a partial fstests run as part of
> 
> Can I take it as a "Reviewed-by" tag? :)

Sure.

> For a quick smoke test
> 
> './check -nfs -g quick'
> 
> (run tests in 'quick' group) will do, it only takes around 10 minutes for me to complete.
> 
> And for something more thoroughly, you can do
> 
> './check -nfs -g auto'

Thanks!

I've got my own handpicked list of tests, partly because I didn't notice
the existance of "quick", partly because there were some failures I
didn't have the time to triage.

> (run tests in 'auto' group), which will take longer time but runs many
> more tests.
> 
> I test every RC release with local-mounted NFS, with NFSv3,
> NFSv4.0/4.1/4.2. Here're the 'known issues' I have for 4.11 kernel (I
> think some failures are false alert, the tests need updates, some
> failures may long standing & low priority bugs on NFS? But I'm not sure
> which is which)
> 
> Failures for all NFS versions:
...

Thanks again!  I'll try to set aside some time to reconcile this with my
own list and see if I can figure out some of the failures.

--b.

  reply	other threads:[~2017-05-25 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 12:09 [RFC PATCH] nfs: test nfs4_getfacl near page size ACL from server Eryu Guan
2017-05-16 15:07 ` J. Bruce Fields
2017-05-17  3:38   ` Eryu Guan
2017-05-17 17:20     ` J. Bruce Fields
2017-05-25  4:01       ` Eryu Guan
2017-05-25 13:26         ` J. Bruce Fields [this message]
2017-05-25 16:59           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525132625.GA6658@parsley.fieldses.org \
    --to=bfields@redhat.com \
    --cc=dros@primarydata.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).