linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 2/2 V2] mount.nfs: Use default minor version when -o v4 is specified
Date: Fri,  9 Jun 2017 09:26:08 -0400	[thread overview]
Message-ID: <20170609132608.12213-2-steved@redhat.com> (raw)
In-Reply-To: <20170609132608.12213-1-steved@redhat.com>

When v4 is specified on the command line the
default minor version needs to be used.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 utils/mount/stropts.c | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index 81fb945..d2d303f 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -119,14 +119,22 @@ static void nfs_default_version(struct nfsmount_info *mi)
 	if (mi->version.v_mode == V_DEFAULT &&
 		config_default_vers.v_mode != V_DEFAULT) {
 		mi->version.major = config_default_vers.major;
-		mi->version.minor = config_default_vers.minor;
+		if (config_default_vers.minor)
+			mi->version.minor = config_default_vers.minor;
+		else if (!mi->version.minor)
+			mi->version.minor = NFS_DEFAULT_MINOR;
 		return;
 	}
 
 	if (mi->version.v_mode == V_GENERAL) {
 		if (config_default_vers.v_mode != V_DEFAULT &&
-		    mi->version.major == config_default_vers.major)
-			mi->version.minor = config_default_vers.minor;
+		    mi->version.major == config_default_vers.major) {
+			if (mi->version.minor)
+				mi->version.minor = config_default_vers.minor;
+			else if (!mi->version.minor)
+				mi->version.minor = NFS_DEFAULT_MINOR;
+		} else if (!mi->version.minor)
+			mi->version.minor = NFS_DEFAULT_MINOR;
 		return;
 	}
 
@@ -740,10 +748,15 @@ static int nfs_do_mount_v4(struct nfsmount_info *mi,
 	}
 
 	if (mi->version.v_mode != V_SPECIFIC) {
-		if (mi->version.v_mode == V_GENERAL)
-			snprintf(version_opt, sizeof(version_opt) - 1,
-				"vers=%lu", mi->version.major);
-		else
+		if (mi->version.v_mode == V_GENERAL) {
+			if (mi->version.major > 3)
+				snprintf(version_opt, sizeof(version_opt) - 1,
+					"vers=%lu.%lu", mi->version.major,
+					mi->version.minor);
+			else 
+				snprintf(version_opt, sizeof(version_opt) - 1,
+					"vers=%lu", mi->version.major);
+		} else
 			snprintf(version_opt, sizeof(version_opt) - 1,
 				"vers=%lu.%lu", mi->version.major,
 				mi->version.minor);
-- 
2.9.4


  reply	other threads:[~2017-06-09 13:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 13:26 [PATCH 1/2 V2] mount.nfs: Use default minor version when -t nfs4 is specified Steve Dickson
2017-06-09 13:26 ` Steve Dickson [this message]
2017-06-13  1:19   ` [PATCH 2/2 V2] mount.nfs: Use default minor version when -o v4 " NeilBrown
2017-06-13 15:21     ` Steve Dickson
2017-06-13 15:54     ` Steve Dickson
2017-06-14  2:09       ` NeilBrown
2017-06-14 10:03         ` Steve Dickson
2017-06-16  3:20           ` NeilBrown
2017-06-19 14:06             ` Steve Dickson
2017-06-20  4:40               ` NeilBrown
2017-06-13  0:59 ` [PATCH 1/2 V2] mount.nfs: Use default minor version when -t nfs4 " NeilBrown
2017-06-13 15:26   ` Steve Dickson
  -- strict thread matches above, loose matches on Subject: below --
2017-06-13 17:31 [PATCH 1/2 V3] " Steve Dickson
2017-06-13 17:31 ` [PATCH 2/2 V2] mount.nfs: Use default minor version when -o v4 " Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609132608.12213-2-steved@redhat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).