From: Greg KH <gregkh@linuxfoundation.org>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: trond.myklebust@primarydata.com, stable@vger.kernel.org,
stable-commits@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Fix up the "supattr_exclcreat" attributes
Date: Mon, 12 Jun 2017 09:40:11 +0200 [thread overview]
Message-ID: <20170612074010.GA19902@kroah.com> (raw)
In-Reply-To: <20170523214449.GI7556@parsley.fieldses.org>
On Tue, May 23, 2017 at 05:44:50PM -0400, J. Bruce Fields wrote:
> From: Trond Myklebust <trond.myklebust@primarydata.com>
>
> commit b26b78cb726007533d81fdf90a62e915002ef5c8 upstream
>
> If an NFSv4 client asks us for the supattr_exclcreat, then we must
> not return attributes that are unsupported by this minor version.
>
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
> Fixes: 75976de6556f ("NFSD: Return word2 bitmask if setting security..,")
> [bfields: use old functions instead of new array in stable backport]
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
> fs/nfsd/nfs4xdr.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> On Tue, May 23, 2017 at 04:38:24PM -0400, J. Bruce Fields wrote:
> > The issue is
> >
> > 916d2d844afd "nfsd: clean up supported attribute handling"
> > dcd208697707 "nfsd: fix supported attributes for acl & labels"
> >
> > which replaced 3 numbered constants by an array, and went in between 4.8
> > and 4.10.
> >
> > But for the purposes of older stable branches, best is probably just to
> > use the old constants. I'll send an updated patch.
>
> Here it is. This should do for 4.9 and older stable branches.
Thanks, now queued up.
greg k-h
next prev parent reply other threads:[~2017-06-12 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <14955646521694@kroah.com>
[not found] ` <20170523192339.GA30111@kroah.com>
2017-05-23 20:38 ` Patch "nfsd: Fix up the "supattr_exclcreat" attributes" has been added to the 4.4-stable tree J. Bruce Fields
2017-05-23 21:44 ` [PATCH] nfsd: Fix up the "supattr_exclcreat" attributes J. Bruce Fields
2017-06-12 7:40 ` Greg KH [this message]
2017-05-09 20:24 Trond Myklebust
2017-05-09 20:56 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612074010.GA19902@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).