From: Stefan Hajnoczi <stefanha@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: Jeff Layton <jlayton@redhat.com>,
Abbas Naderi <abiusx@google.com>,
Steve Dickson <steved@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH nfs-utils v2 01/12] mount: don't use IPPROTO_UDP for address resolution
Date: Fri, 30 Jun 2017 14:21:09 +0100 [thread overview]
Message-ID: <20170630132120.31578-2-stefanha@redhat.com> (raw)
In-Reply-To: <20170630132120.31578-1-stefanha@redhat.com>
Although getaddrinfo(3) with IPPROTO_UDP works fine for AF_INET and
AF_INET6, the AF_VSOCK address family does not support IPPROTO_UDP and
produces an error.
Drop IPPROTO_UDP and use the 0 default (TCP) which works for all address
families. Modern NFS uses TCP anyway so it's strange to specify UDP.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
---
utils/mount/stropts.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index c2a739b..99656dd 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -909,9 +909,7 @@ static int nfs_try_mount(struct nfsmount_info *mi)
int result = 0;
if (mi->address == NULL) {
- struct addrinfo hint = {
- .ai_protocol = (int)IPPROTO_UDP,
- };
+ struct addrinfo hint = {};
int error;
struct addrinfo *address;
--
2.9.4
next prev parent reply other threads:[~2017-06-30 13:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 13:21 [PATCH nfs-utils v2 00/12] add NFS over AF_VSOCK support Stefan Hajnoczi
2017-06-30 13:21 ` Stefan Hajnoczi [this message]
2017-06-30 14:34 ` [PATCH nfs-utils v2 01/12] mount: don't use IPPROTO_UDP for address resolution Steve Dickson
2017-07-03 8:55 ` Stefan Hajnoczi
2017-07-03 16:35 ` Steve Dickson
2017-06-30 13:21 ` [PATCH nfs-utils v2 02/12] nfs-utils: add AF_VSOCK support to sockaddr.h Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 03/12] mount: present AF_VSOCK addresses Stefan Hajnoczi
2017-06-30 14:40 ` Steve Dickson
2017-07-03 9:00 ` Stefan Hajnoczi
2017-07-03 16:51 ` Steve Dickson
2017-07-03 21:04 ` Felix Janda
2017-07-10 18:14 ` Stefan Hajnoczi
2017-07-12 14:26 ` Steve Dickson
2017-07-06 17:16 ` J. Bruce Fields
2017-07-10 18:09 ` Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 04/12] mount: accept AF_VSOCK in nfs_verify_family() Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 05/12] getport: recognize "vsock" netid Stefan Hajnoczi
2017-06-30 15:01 ` Steve Dickson
2017-07-10 18:35 ` Stefan Hajnoczi
2017-06-30 15:52 ` Chuck Lever
2017-07-07 3:17 ` NeilBrown
2017-07-07 4:13 ` NeilBrown
2017-07-25 10:05 ` Stefan Hajnoczi
2017-07-27 5:13 ` NeilBrown
2017-07-27 10:58 ` Stefan Hajnoczi
2017-07-27 11:33 ` Jeff Layton
2017-07-27 23:11 ` NeilBrown
2017-08-03 15:24 ` Stefan Hajnoczi
2017-08-03 21:45 ` NeilBrown
2017-08-03 23:53 ` Matt Benjamin
2017-08-04 3:25 ` NeilBrown
2017-08-04 15:56 ` Stefan Hajnoczi
2017-08-04 22:35 ` NeilBrown
2017-08-08 14:07 ` Stefan Hajnoczi
2017-07-07 4:14 ` Chuck Lever
2017-07-25 12:29 ` Stefan Hajnoczi
2017-07-19 15:11 ` Stefan Hajnoczi
2017-07-19 15:35 ` Jeff Layton
2017-07-19 15:40 ` Chuck Lever
2017-07-19 15:50 ` Chuck Lever
2017-07-28 0:35 ` Matt Benjamin
2017-06-30 13:21 ` [PATCH nfs-utils v2 06/12] mount: AF_VSOCK address parsing Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 07/12] exportfs: introduce host_freeaddrinfo() Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 08/12] exportfs: add AF_VSOCK address parsing and printing Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 09/12] exportfs: add AF_VSOCK support to set_addrlist() Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 10/12] exportfs: add support for "vsock:" exports(5) syntax Stefan Hajnoczi
2017-06-30 15:07 ` Steve Dickson
2017-06-30 13:21 ` [PATCH nfs-utils v2 11/12] nfsd: add --vsock (-v) option to nfsd Stefan Hajnoczi
2017-06-30 15:25 ` Steve Dickson
2017-07-10 18:39 ` Stefan Hajnoczi
2017-06-30 13:21 ` [PATCH nfs-utils v2 12/12] tests: add "vsock:" exports(5) test case Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630132120.31578-2-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=abiusx@google.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox