Linux NFS development
 help / color / mirror / Atom feed
From: Scott Mayhew <smayhew@redhat.com>
To: NeilBrown <neilb@suse.com>
Cc: steved@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH v4] systemd: add instructions for disabling gssd to nfs.systemd.man
Date: Tue, 25 Jul 2017 11:18:58 -0400	[thread overview]
Message-ID: <20170725151858.giqjb6dhogrl4lvj@tonberry.usersys.redhat.com> (raw)
In-Reply-To: <874lu4xete.fsf@notabene.neil.brown.name>

On Sun, 23 Jul 2017, NeilBrown wrote:

> On Sat, Jul 22 2017, Scott Mayhew wrote:
> 
> > On Sat, 22 Jul 2017, NeilBrown wrote:
> >
> >> On Thu, Jul 20 2017, Scott Mayhew wrote:
> >> 
> >> > We've had several users complain about gssd automatically starting.  Not
> >> > everyone who has a krb5.keytab want to use secure NFS; the instructions
> >> > for disabling gssd ought to be on the man page in addition to the README
> >> > (which may not even be included in a distro's nfs-utils package).
> >> >
> >> > Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> >> > ---
> >> >  systemd/nfs.systemd.man | 17 ++++++++++++++++-
> >> >  1 file changed, 16 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/systemd/nfs.systemd.man b/systemd/nfs.systemd.man
> >> > index 01801eb..7675320 100644
> >> > --- a/systemd/nfs.systemd.man
> >> > +++ b/systemd/nfs.systemd.man
> >> > @@ -79,11 +79,26 @@ unit should be enabled.
> >> >  Several other units which might be considered to be optional, such as
> >> >  .I rpc-gssd.service
> >> >  are careful to only start if the required configuration file exists.
> >> > -.I rpc-gsdd.service
> >> > +.I rpc-gssd.service
> >> >  will not start if the
> >> >  .I krb5.keytab
> >> >  file does not exist (typically in
> >> >  .IR /etc ).
> >> > +.B rpc.gssd
> >> > +is assumed to be needed if the
> >> > +.I krb5.keytab
> >> > +file is present.  If a site needs this file present but does not want
> >> > +.B rpc.gssd
> >> > +running, it should create
> >> > +.B /etc/systemd/system/rpc-gssd.service.d/01-disable.conf
> >> 
> >> A substantially simpler approach would be to recommend
> >> 
> >>   systemctl mask rpc-gssd.service
> >
> > Thanks, Neil.  I had actually tried that a while back, but it doesn't seem
> > to work in RHEL.  It works fine for rpcbind, so I thought that maybe the
> > Condition clause in the unit file took precedence over masking or
> > something.  I see now that masking rpc-gssd works in Fedora, so I'll go
> > digging in systemd to see if there's a bug fix that might need to be
> > backported to RHEL.
> >
> > Anyways, any objection to listing both methods in the man page?
> 
> It depends on why "mask" doesn't work in RHEL.
> If the reason is specific to RHEL, then I don't think it should be
> documented in upstream nfs-utils.
> If the reason is specific to some version(s) of systemd, then
> Maybe document it as "use using systemd prior to XXXX, do this instead".

It turns out that we have rpc-gssd.service symlinked to
nfs-secure.service in both RHEL and Fedora for backward compatibility
purposes, so it's necessary to mask both.

I'll send a patch documenting masking just the rpc-gssd.service.

-Scott
> 
> NeilBrown
> 
> 
> >
> > -Scott
> >> 
> >> "mask" is also useful for disabling rpcbind if you use NFSv4 only and
> >> don't want the extra service.
> >> 
> >> NeilBrown
> >> 
> >> 
> >> > +containing
> >> > +.RS
> >> > +.nf
> >> > +[Unit]
> >> > +ConditionNull=false
> >> > +.fi
> >> > +.RE
> >> > +
> >> >  .SS Restarting NFS services
> >> >  Most NFS daemons can be restarted at any time.  They will reload any
> >> >  state that they need, and continue servicing requests.  This is rarely
> >> > -- 
> >> > 2.9.4
> >> >
> >> > --
> >> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >> > the body of a message to majordomo@vger.kernel.org
> >> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html



  reply	other threads:[~2017-07-25 15:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 20:24 [nfs-utils PATCH v4] systemd: add instructions for disabling gssd to nfs.systemd.man Scott Mayhew
2017-07-22  8:48 ` NeilBrown
2017-07-22 16:25   ` Scott Mayhew
2017-07-22 22:54     ` NeilBrown
2017-07-25 15:18       ` Scott Mayhew [this message]
2017-07-25 22:16         ` NeilBrown
2017-07-25 15:19   ` [nfs-utils PATCH] systemd: add a blurb about masking rpc-gssd to the man page Scott Mayhew
2017-07-25 22:20     ` NeilBrown
2017-07-26 18:05     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725151858.giqjb6dhogrl4lvj@tonberry.usersys.redhat.com \
    --to=smayhew@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox