linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH v2 0/6] RPC client latency fixes
Date: Wed, 16 Aug 2017 12:19:23 -0400	[thread overview]
Message-ID: <20170816161929.11271-1-trond.myklebust@primarydata.com> (raw)

The following patches apply on top of the writeback patches sent last
week. They start the process of reducing contention in the RPC client
receive code due to excessive holding of the transport lock.

The first patch is the most important in that it allows the client to
drop the transport lock while copying data from the socket into the
RPC call's reply buffers.
The second ensures that we don't keep hogging the workqueue worker thread
forever, but that we reschedule the receive job if it keeps looping.
Finally, a small cleanup to avoid having to make a copy of the
struct xdr_skb_reader on the stack.

v2: Reorder patches to add I/O throttling after the core RPC latency
changes
    Fix a crash when receiving backchannel requests.

Trond Myklebust (6):
  SUNRPC: Don't hold the transport lock across socket copy operations
  SUNRPC: Don't hold the transport lock when receiving backchannel data
  SUNRPC: Don't loop forever in xs_tcp_data_receive()
  SUNRPC: Cleanup xs_tcp_read_common()
  SUNRPC: Add a function to allow waiting for RPC transmission
  NFS: Throttle I/O to the NFS server

 fs/nfs/pagelist.c             |  3 +-
 include/linux/sunrpc/sched.h  |  5 ++++
 include/linux/sunrpc/xprt.h   |  2 ++
 net/sunrpc/backchannel_rqst.c |  4 +--
 net/sunrpc/sched.c            | 22 +++++++++++++++
 net/sunrpc/xprt.c             | 48 +++++++++++++++++++++++++++++++
 net/sunrpc/xprtsock.c         | 66 ++++++++++++++++++++++---------------------
 7 files changed, 115 insertions(+), 35 deletions(-)

-- 
2.13.5


             reply	other threads:[~2017-08-16 16:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 16:19 Trond Myklebust [this message]
2017-08-16 16:19 ` [PATCH v2 1/6] SUNRPC: Don't hold the transport lock across socket copy operations Trond Myklebust
2017-08-16 16:19   ` [PATCH v2 2/6] SUNRPC: Don't hold the transport lock when receiving backchannel data Trond Myklebust
2017-08-16 16:19     ` [PATCH v2 3/6] SUNRPC: Don't loop forever in xs_tcp_data_receive() Trond Myklebust
2017-08-16 16:19       ` [PATCH v2 4/6] SUNRPC: Cleanup xs_tcp_read_common() Trond Myklebust
2017-08-16 16:19         ` [PATCH v2 5/6] SUNRPC: Add a function to allow waiting for RPC transmission Trond Myklebust
2017-08-16 16:19           ` [PATCH v2 6/6] NFS: Throttle I/O to the NFS server Trond Myklebust
2017-08-16 16:43           ` [PATCH v2 5/6] SUNRPC: Add a function to allow waiting for RPC transmission Chuck Lever
2017-08-16 20:02             ` Trond Myklebust
2017-08-16 20:03               ` Chuck Lever
2017-08-16 18:54   ` [PATCH v2 1/6] SUNRPC: Don't hold the transport lock across socket copy operations Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170816161929.11271-1-trond.myklebust@primarydata.com \
    --to=trond.myklebust@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).