Pull request for pynfs

Pull request for pynfs

[Frank Filz]

Bruce,

Please pull from https://github.com/ffilz/pynfs/commits/master

This patch fixes CSESS29 to issue the invalid CREATE_SESSION inside a valid
session so that the SEQUENCE op will renew the lease on the clientid. This
test may take sufficient time on some servers to have the unconfirmed
clientid expire, requiring setting a long lease period for testing that
impacts the overall run time.

Thanks

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: Pull request for pynfs

[J. Bruce Fields]

Sorry for the delay--I've taken that patch, thanks!

(BTW, for future reference the URL I need is
https://github.com/ffilz/pynfs.git.)

--b.

On Mon, Aug 14, 2017 at 04:55:48PM -0700, Frank Filz wrote:
> Bruce,
> 
> Please pull from https://github.com/ffilz/pynfs/commits/master
> 
> This patch fixes CSESS29 to issue the invalid CREATE_SESSION inside a valid
> session so that the SEQUENCE op will renew the lease on the clientid. This
> test may take sufficient time on some servers to have the unconfirmed
> clientid expire, requiring setting a long lease period for testing that
> impacts the overall run time.
> 
> Thanks
> 
> Frank
> 
> 
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Pull request for pynfs

[Frank Filz]

Bruce,

Please pull the top patch from:

https://github.com/ffilz/pynfs/commits/master

It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different principal
replaces a clientid that has no state, and adds CID2a which expects
NFS4ERR_CLID_INUSE since it does have state.

Thanks

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: Pull request for pynfs

[Bruce Fields]

On Fri, Oct 16, 2015 at 01:44:42PM -0700, Frank Filz wrote:
> Bruce,
> 
> Please pull the top patch from:
> 
> https://github.com/ffilz/pynfs/commits/master
> 
> It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different principal
> replaces a clientid that has no state, and adds CID2a which expects
> NFS4ERR_CLID_INUSE since it does have state.

Thanks!

This leave us with two test functions both named "testInUse".

I applied the following to get both tests working.

--b.

diff --git a/nfs4.0/servertests/st_setclientid.py b/nfs4.0/servertests/st_setclientid.py
index 0fb59cd7f542..fbeab22e5026 100644
--- a/nfs4.0/servertests/st_setclientid.py
+++ b/nfs4.0/servertests/st_setclientid.py
@@ -50,7 +50,7 @@ def testClientUpdateCallback(t, env):
     res = c.close_file(t.code, fh, stateid)
     check(res, msg="Close after updating callback info")
     
-def testInUse(t, env):
+def testNotInUse(t, env):
     """SETCLIENTID with same nfs_client_id.id should return NFS4ERR_OK
        if there is no active state
 

RE: Pull request for pynfs

[Frank Filz]

> On Fri, Oct 16, 2015 at 01:44:42PM -0700, Frank Filz wrote:
> > Bruce,
> >
> > Please pull the top patch from:
> >
> > https://github.com/ffilz/pynfs/commits/master
> >
> > It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different
> > principal replaces a clientid that has no state, and adds CID2a which
> > expects NFS4ERR_CLID_INUSE since it does have state.
> 
> Thanks!
> 
> This leave us with two test functions both named "testInUse".
> 
> I applied the following to get both tests working.

Oops, sorry...

Frank

> diff --git a/nfs4.0/servertests/st_setclientid.py
> b/nfs4.0/servertests/st_setclientid.py
> index 0fb59cd7f542..fbeab22e5026 100644
> --- a/nfs4.0/servertests/st_setclientid.py
> +++ b/nfs4.0/servertests/st_setclientid.py
> @@ -50,7 +50,7 @@ def testClientUpdateCallback(t, env):
>      res = c.close_file(t.code, fh, stateid)
>      check(res, msg="Close after updating callback info")
> 
> -def testInUse(t, env):
> +def testNotInUse(t, env):
>      """SETCLIENTID with same nfs_client_id.id should return NFS4ERR_OK
>         if there is no active state
> 


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus