From: "J. Bruce Fields" <bfields@fieldses.org>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@poochiereds.net>
Subject: Re: [PATCH] nlm_shutdown_hosts_net() cleanup
Date: Mon, 30 Oct 2017 10:49:43 -0400 [thread overview]
Message-ID: <20171030144943.GG14098@fieldses.org> (raw)
In-Reply-To: <1d1a25d8-a34b-5175-bb6a-9549041c11f4@virtuozzo.com>
On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote:
> nlm_complain_hosts() walk through nlm_server_hosts hlist that should be
> protected by nlm_host_mutex.
I haven't looked at the NLM locking in ages. Do we know who else might
actually be accessing this list concurrently?
--b.
>
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
> fs/lockd/host.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> index d716c99..089c1d7 100644
> --- a/fs/lockd/host.c
> +++ b/fs/lockd/host.c
> @@ -617,9 +617,8 @@ nlm_shutdown_hosts_net(struct net *net)
>
> /* Then, perform a garbage collection pass */
> nlm_gc_hosts(net);
> - mutex_unlock(&nlm_host_mutex);
> -
> nlm_complain_hosts(net);
> + mutex_unlock(&nlm_host_mutex);
> }
>
> /*
> --
> 2.7.4
next prev parent reply other threads:[~2017-10-30 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 13:47 [PATCH] nlm_shutdown_hosts_net() cleanup Vasily Averin
2017-10-30 14:49 ` J. Bruce Fields [this message]
2017-10-30 14:58 ` Vasily Averin
2017-10-30 15:49 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030144943.GG14098@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).