Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andrew W Elble <aweits@rit.edu>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] nfsd: fix locking validator warning on nfs4_ol_stateid->st_mutex class
Date: Wed, 8 Nov 2017 16:43:44 -0500	[thread overview]
Message-ID: <20171108214344.GQ24262@fieldses.org> (raw)
In-Reply-To: <m21sl8o3bd.fsf@discipline.rit.edu>

On Wed, Nov 08, 2017 at 04:42:14PM -0500, Andrew W Elble wrote:
> "J. Bruce Fields" <bfields@fieldses.org> writes:
> 
> > On Tue, Nov 07, 2017 at 07:57:26PM -0500, Andrew Elble wrote:
> >> The use of the st_mutex has been confusing the validator. Use the
> >> proper nested notation so as to not produce warnings.
> >
> > Looking around, the usual pattern for simple nesting seems to be to use
> > just mutex_lock() for the outer lock (equivalent to
> > mutex_lock_nested(0)), and mutex_lock_nested(., SINGLE_DEPTH_NESTING)
> > for the inner lock.
> >
> > Or we could define a new LOCK_STATEID_MUTEX, assuming the rule here is
> > "lock stateid's are locked after open stateid's".  Just a question of
> > might be simpler to understand.
> 
> I'm okay with whatever you think is best here - my thought was that the
> mutex_lock_nested(0) called more attention to how it was working given
> that acquiring that lock class the second time is now a little bit more
> hidden in nfsd4_lock_ol_stateid().

I think I'd go for constants like OPEN_STATEID_MUTEX and
LOCK_STATEID_MUTEX in that case.  Maybe mild overkill, but it should
explain what's going on?

--b.

      reply	other threads:[~2017-11-08 21:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  0:57 [PATCH v2] nfsd: fix locking validator warning on nfs4_ol_stateid->st_mutex class Andrew Elble
2017-11-08 20:58 ` J. Bruce Fields
2017-11-08 21:42   ` Andrew W Elble
2017-11-08 21:43     ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108214344.GQ24262@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=aweits@rit.edu \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox