From: Joshua Watt <jpewhacker@gmail.com>
To: NeilBrown <neilb@suse.com>, Jeff Layton <jlayton@redhat.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
"J . Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Joshua Watt <JPEWhacker@gmail.com>
Subject: [RFC v4 9/9] NFS: Kill all client RPCs if transient
Date: Fri, 17 Nov 2017 11:45:52 -0600 [thread overview]
Message-ID: <20171117174552.18722-10-JPEWhacker@gmail.com> (raw)
In-Reply-To: <20171117174552.18722-1-JPEWhacker@gmail.com>
When unmounting with the MNT_FORCE flag, all client RPCs will be killed
in all mount points if the mount is transient
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
fs/nfs/super.c | 40 ++++++++++++++++++++++++++++++++++++----
1 file changed, 36 insertions(+), 4 deletions(-)
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 09c413c098ef..f97cec1a1dec 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -904,6 +904,18 @@ kill_rpc(struct rpc_clnt *rpc)
}
}
+static void
+kill_client_rpc(struct nfs_client *client)
+{
+ struct nfs_server *server;
+
+ kill_rpc(client->cl_rpcclient);
+ list_for_each_entry_rcu(server, &client->cl_superblocks, client_link) {
+ kill_rpc(server->client_acl);
+ kill_rpc(server->client);
+ }
+}
+
/*
* Begin unmount by attempting to remove all automounted mountpoints we added
* in response to xdev traversals and referrals
@@ -914,8 +926,12 @@ void nfs_umount_begin(struct super_block *sb)
server = NFS_SB(sb);
/* -EIO all pending I/O */
- kill_rpc(server->client_acl);
- kill_rpc(server->client);
+ if (server->flags & NFS_MOUNT_TRANSIENT) {
+ kill_client_rpc(server->nfs_client);
+ } else {
+ kill_rpc(server->client_acl);
+ kill_rpc(server->client);
+ }
}
EXPORT_SYMBOL_GPL(nfs_umount_begin);
@@ -926,13 +942,29 @@ restore_rpc(struct rpc_clnt *rpc)
__atomic_add_unless(&rpc->cl_kill_new_tasks, -1, 0);
}
+static void
+restore_client_rpc(struct nfs_client *client)
+{
+ struct nfs_server *server;
+
+ restore_rpc(client->cl_rpcclient);
+ list_for_each_entry_rcu(server, &client->cl_superblocks, client_link) {
+ restore_rpc(server->client_acl);
+ restore_rpc(server->client);
+ }
+}
+
void
nfs_umount_end(struct super_block *sb)
{
struct nfs_server *server = NFS_SB(sb);
- restore_rpc(server->client_acl);
- restore_rpc(server->client);
+ if (server->flags & NFS_MOUNT_TRANSIENT) {
+ restore_client_rpc(server->nfs_client);
+ } else {
+ restore_rpc(server->client_acl);
+ restore_rpc(server->client);
+ }
}
EXPORT_SYMBOL_GPL(nfs_umount_end);
--
2.13.6
next prev parent reply other threads:[~2017-11-17 17:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 17:45 [RFC v4 0/9] NFS Force Unmounting Joshua Watt
2017-11-17 17:45 ` [RFC v4 1/9] SUNRPC: Add flag to kill new tasks Joshua Watt
2017-12-05 22:59 ` NeilBrown
2017-11-17 17:45 ` [RFC v4 2/9] SUNRPC: Expose kill_new_tasks in debugfs Joshua Watt
2017-11-17 17:45 ` [RFC v4 3/9] SUNRPC: Simplify client shutdown Joshua Watt
2017-11-17 17:45 ` [RFC v4 4/9] namespace: Add umount_end superblock operation Joshua Watt
2017-12-06 11:54 ` Jeff Layton
2017-12-06 12:14 ` Al Viro
2017-12-06 12:33 ` Al Viro
2017-12-06 15:41 ` Joshua Watt
2017-11-17 17:45 ` [RFC v4 5/9] NFS: Kill RPCs for the duration of umount Joshua Watt
2017-12-05 23:07 ` NeilBrown
2017-11-17 17:45 ` [RFC v4 6/9] NFS: Add debugfs for nfs_server and nfs_client Joshua Watt
2017-11-17 17:45 ` [RFC v4 7/9] NFS: Add transient mount option Joshua Watt
2017-12-06 12:23 ` Jeff Layton
2017-11-17 17:45 ` [RFC v4 8/9] NFS: Don't shared transient clients Joshua Watt
2017-11-17 17:45 ` Joshua Watt [this message]
2017-12-04 14:36 ` [RFC v4 0/9] NFS Force Unmounting Joshua Watt
2017-12-05 23:34 ` NeilBrown
2017-12-06 13:03 ` Jeff Layton
2017-12-06 16:40 ` Joshua Watt
2017-12-08 2:10 ` NeilBrown
2017-12-14 18:22 ` Joshua Watt
2017-12-14 21:52 ` NeilBrown
2017-12-18 21:48 ` Joshua Watt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117174552.18722-10-JPEWhacker@gmail.com \
--to=jpewhacker@gmail.com \
--cc=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).