Linux NFS development
 help / color / mirror / Atom feed
From: Lennart Poettering <lennart@poettering.net>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>,
	Systemd Mailing List <systemd-devel@lists.freedesktop.org>
Subject: Re: [systemd-devel] [PATCH] rpcbind.service: Not pulling the rpcbind.target
Date: Thu, 14 Dec 2017 19:05:51 +0100	[thread overview]
Message-ID: <20171214180551.GA15603@gardel-login> (raw)
In-Reply-To: <20171214170544.11793-1-steved@redhat.com>

On Do, 14.12.17 12:05, Steve Dickson (steved@redhat.com) wrote:

> According to systemd.special(7) manpage:
> 
> rpcbind.target
>     The portmapper/rpcbind pulls in this target and
>     orders itself before it, to indicate its availability. systemd
>     automatically adds dependencies of type After= for this target
>     unit to all SysV init script service units with an LSB header
>     referring to the "$portmap" facility.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  systemd/rpcbind.service.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
> index f8cfa9f..2b49c24 100644
> --- a/systemd/rpcbind.service.in
> +++ b/systemd/rpcbind.service.in
> @@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
>  
>  # Make sure we use the IP addresses listed for
>  # rpcbind.socket, no matter how this unit is started.
> -Wants=rpcbind.socket
> -After=rpcbind.socket
> +Wants=rpcbind.socket rpcbind.target
> +After=rpcbind.socket rpcbind.target

The last line should be:

After=rpcbind.socket
Before=rpcbind.target

Lennart

-- 
Lennart Poettering, Red Hat

      parent reply	other threads:[~2017-12-14 18:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 17:05 [PATCH] rpcbind.service: Not pulling the rpcbind.target Steve Dickson
2017-12-14 17:48 ` [systemd-devel] " Uoti Urpala
2017-12-14 18:24   ` Steve Dickson
2017-12-14 18:47     ` Uoti Urpala
2017-12-14 20:20       ` Steve Dickson
2017-12-14 18:05 ` Lennart Poettering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214180551.GA15603@gardel-login \
    --to=lennart@poettering.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    --cc=systemd-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox