From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 6/7] Removed missing-include-dirs warnings
Date: Tue, 20 Feb 2018 13:50:33 -0500 [thread overview]
Message-ID: <20180220185034.26301-7-steved@redhat.com> (raw)
In-Reply-To: <20180220185034.26301-1-steved@redhat.com>
Added the -Werror=missing-include-dirs warning flag
then moved some include directories around.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
configure.ac | 3 ++-
support/nfs/wildmat.c | 6 ++++++
utils/gssd/Makefile.am | 2 ++
utils/idmapd/Makefile.am | 2 ++
utils/nfsidmap/Makefile.am | 2 ++
5 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 2364275..b849f43 100644
--- a/configure.ac
+++ b/configure.ac
@@ -448,7 +448,7 @@ if test -n "$path_plugins" ; then
fi
AM_CONDITIONAL(PATH_PLUGINS, test -n "$path_plugins")
-AC_SUBST(AM_CPPFLAGS, "$AM_CPPFLAGS -I../../support/nfsidmap")
+AC_SUBST(AM_CPPFLAGS, "$AM_CPPFLAGS")
AC_DEFINE([HAVE_NFS4_SET_DEBUG], 1,
[Bundled lib always has the `nfs4_set_debug' function.])
@@ -553,6 +553,7 @@ my_am_cflags="\
-Werror=format-overflow=2 \
-Werror=format=2 \
-Werror=undef \
+ -Werror=missing-include-dirs \
"
AC_SUBST([AM_CFLAGS], ["$my_am_cflags"])
diff --git a/support/nfs/wildmat.c b/support/nfs/wildmat.c
index 2f40358..437b2d1 100644
--- a/support/nfs/wildmat.c
+++ b/support/nfs/wildmat.c
@@ -43,8 +43,14 @@
#include <ctype.h>
#include "nfslib.h"
+#ifndef TRUE
#define TRUE 1
+#endif
+
+#ifndef FALSE
#define FALSE 0
+#endif
+
#define ABORT -1
diff --git a/utils/gssd/Makefile.am b/utils/gssd/Makefile.am
index beb3e8e..321046b 100644
--- a/utils/gssd/Makefile.am
+++ b/utils/gssd/Makefile.am
@@ -5,6 +5,8 @@ if CONFIG_SVCGSS
man8_MANS += svcgssd.man
endif
+AM_CPPFLAGS += -I ../../support/nfsidmap
+
RPCPREFIX = rpc.
KPREFIX = @kprefix@
sbin_PREFIXED = gssd
diff --git a/utils/idmapd/Makefile.am b/utils/idmapd/Makefile.am
index d768eec..e09e8c5 100644
--- a/utils/idmapd/Makefile.am
+++ b/utils/idmapd/Makefile.am
@@ -2,6 +2,8 @@
man8_MANS = idmapd.man
+AM_CPPFLAGS += -I ../../support/nfsidmap
+
RPCPREFIX = rpc.
KPREFIX = @kprefix@
sbin_PROGRAMS = idmapd
diff --git a/utils/nfsidmap/Makefile.am b/utils/nfsidmap/Makefile.am
index 49158df..e5d7d04 100644
--- a/utils/nfsidmap/Makefile.am
+++ b/utils/nfsidmap/Makefile.am
@@ -3,6 +3,8 @@
man8_MANS = nfsidmap.man
sbin_PROGRAMS = nfsidmap
+AM_CPPFLAGS += -I ../../support/nfsidmap
+
nfsidmap_SOURCES = nfsidmap.c
nfsidmap_LDADD = -lkeyutils \
../../support/nfs/libnfs.la \
--
2.14.3
next prev parent reply other threads:[~2018-02-20 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 18:50 [PATCH 0/7] nfs-utils: Use -Werror warning flags to clean up the code Steve Dickson
2018-02-20 18:50 ` [PATCH 1/7] configure.ac: clean up Steve Dickson
2018-02-20 18:50 ` [PATCH 2/7] Removed missing-prototypes warnings Steve Dickson
2018-02-20 18:50 ` [PATCH 3/7] Removed format-overflow=2 warnings Steve Dickson
2018-02-20 18:50 ` [PATCH 4/7] Removed format=2 warnings Steve Dickson
2018-02-20 18:50 ` [PATCH 5/7] Removed undef warnings Steve Dickson
2018-02-20 18:50 ` Steve Dickson [this message]
2018-02-20 18:50 ` [PATCH 7/7] Added more -Werror= warning flags Steve Dickson
2018-02-23 14:21 ` [PATCH 0/7] nfs-utils: Use -Werror warning flags to clean up the code Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220185034.26301-7-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).