From: "J . Bruce Fields" <bfields@fieldses.org>
To: Colin King <colin.king@canonical.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static
Date: Wed, 21 Feb 2018 19:50:35 -0500 [thread overview]
Message-ID: <20180222005035.GG6535@fieldses.org> (raw)
In-Reply-To: <20180207102947.29292-1-colin.king@canonical.com>
Thanks, applying.--b.
On Wed, Feb 07, 2018 at 10:29:47AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variables nlm_ntf_refcnt and nlm_ntf_wq are local to the source and
> do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> fs/lockd/svc.c:60:10: warning: symbol 'nlm_ntf_refcnt' was not declared.
> Should it be static?
> fs/lockd/svc.c:61:1: warning: symbol 'nlm_ntf_wq' was not declared.
> Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/lockd/svc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index 9c36d614bf89..346ed161756d 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -57,8 +57,8 @@ static struct task_struct *nlmsvc_task;
> static struct svc_rqst *nlmsvc_rqst;
> unsigned long nlmsvc_timeout;
>
> -atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
> -DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
> +static atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
> +static DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
>
> unsigned int lockd_net_id;
>
> --
> 2.15.1
prev parent reply other threads:[~2018-02-22 0:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 10:29 [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static Colin King
2018-02-22 0:50 ` J . Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222005035.GG6535@fieldses.org \
--to=bfields@fieldses.org \
--cc=anna.schumaker@netapp.com \
--cc=colin.king@canonical.com \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).