* [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static
@ 2018-02-07 10:29 Colin King
2018-02-22 0:50 ` J . Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-02-07 10:29 UTC (permalink / raw)
To: J . Bruce Fields, Jeff Layton, Trond Myklebust, Anna Schumaker,
linux-nfs
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variables nlm_ntf_refcnt and nlm_ntf_wq are local to the source and
do not need to be in global scope, so make them static.
Cleans up sparse warnings:
fs/lockd/svc.c:60:10: warning: symbol 'nlm_ntf_refcnt' was not declared.
Should it be static?
fs/lockd/svc.c:61:1: warning: symbol 'nlm_ntf_wq' was not declared.
Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/lockd/svc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 9c36d614bf89..346ed161756d 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -57,8 +57,8 @@ static struct task_struct *nlmsvc_task;
static struct svc_rqst *nlmsvc_rqst;
unsigned long nlmsvc_timeout;
-atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
-DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
+static atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
+static DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
unsigned int lockd_net_id;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static
2018-02-07 10:29 [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static Colin King
@ 2018-02-22 0:50 ` J . Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J . Bruce Fields @ 2018-02-22 0:50 UTC (permalink / raw)
To: Colin King
Cc: Jeff Layton, Trond Myklebust, Anna Schumaker, linux-nfs,
kernel-janitors, linux-kernel
Thanks, applying.--b.
On Wed, Feb 07, 2018 at 10:29:47AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variables nlm_ntf_refcnt and nlm_ntf_wq are local to the source and
> do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> fs/lockd/svc.c:60:10: warning: symbol 'nlm_ntf_refcnt' was not declared.
> Should it be static?
> fs/lockd/svc.c:61:1: warning: symbol 'nlm_ntf_wq' was not declared.
> Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/lockd/svc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index 9c36d614bf89..346ed161756d 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -57,8 +57,8 @@ static struct task_struct *nlmsvc_task;
> static struct svc_rqst *nlmsvc_rqst;
> unsigned long nlmsvc_timeout;
>
> -atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
> -DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
> +static atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
> +static DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
>
> unsigned int lockd_net_id;
>
> --
> 2.15.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-22 0:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-07 10:29 [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static Colin King
2018-02-22 0:50 ` J . Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).