From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 11/15] nfsd: Record request byte count, not count of vectors
Date: Wed, 14 Mar 2018 16:52:50 -0400 [thread overview]
Message-ID: <20180314205250.GC7241@fieldses.org> (raw)
In-Reply-To: <20180313154437.21531.89300.stgit@klimt.1015granger.net>
On Tue, Mar 13, 2018 at 11:44:37AM -0400, Chuck Lever wrote:
> TP_fast_assign(
> __entry->xid = be32_to_cpu(rqstp->rq_xid);
> - do {
> - struct knfsd_fh fh;
> -
> - fh_copy_shallow(&fh, &fhp->fh_handle);
> - __entry->fh_hash = knfsd_fh_hash(&fh);
> - } while (0);
> + __entry->fh_hash = knfsd_fh_hash(&fhp->fh_handle);
> __entry->offset = offset;
> __entry->len = len;
> ),
What's that about? Why did someone originally think we needed to copy
before hashing?
--b.
next prev parent reply other threads:[~2018-03-14 20:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 15:43 [PATCH 00/15] NFSD trace point clean up Chuck Lever
2018-03-13 15:43 ` [PATCH 01/15] sunrpc: Remove unneeded pointer dereference Chuck Lever
2018-03-13 15:43 ` [PATCH 02/15] svc: Simplify ->xpo_secure_port Chuck Lever
2018-03-13 15:43 ` [PATCH 03/15] sunrpc: Update show_svc_xprt_flags() to include recently added flags Chuck Lever
2018-03-13 15:44 ` [PATCH 04/15] sunrpc: Move trace_svc_xprt_dequeue() Chuck Lever
2018-03-13 15:44 ` [PATCH 05/15] sunrpc: Simplify do_enqueue tracing Chuck Lever
2018-03-13 15:44 ` [PATCH 06/15] sunrpc: Simplify trace_svc_recv Chuck Lever
2018-03-13 15:44 ` [PATCH 07/15] sunrpc: Save remote presentation address in svc_xprt for trace events Chuck Lever
2018-03-14 20:35 ` J. Bruce Fields
2018-03-15 0:54 ` Chuck Lever
2018-03-15 1:43 ` Bruce Fields
2018-03-13 15:44 ` [PATCH 08/15] sunrpc: Re-purpose trace_svc_process Chuck Lever
2018-03-13 15:44 ` [PATCH 09/15] sunrpc: Report per-RPC execution stats Chuck Lever
2018-03-14 20:50 ` J. Bruce Fields
2018-03-15 1:11 ` Chuck Lever
2018-03-22 20:32 ` Chuck Lever
2018-03-22 21:01 ` Bruce Fields
2018-03-22 21:18 ` Chuck Lever
2018-03-13 15:44 ` [PATCH 10/15] nfsd: Fix NFSD trace points Chuck Lever
2018-03-13 15:44 ` [PATCH 11/15] nfsd: Record request byte count, not count of vectors Chuck Lever
2018-03-14 20:52 ` J. Bruce Fields [this message]
2018-03-15 1:18 ` Chuck Lever
2018-03-13 15:44 ` [PATCH 12/15] nfsd: Add "nfsd_" to trace point names Chuck Lever
2018-03-13 15:44 ` [PATCH 13/15] nfsd: Add I/O trace points in the NFSv4 write path Chuck Lever
2018-03-13 15:44 ` [PATCH 14/15] nfsd: Add I/O trace points in the NFSv4 read proc Chuck Lever
2018-03-13 15:44 ` [PATCH 15/15] nfsd: Trace NFSv4 COMPOUND execution Chuck Lever
2018-03-14 20:55 ` J. Bruce Fields
2018-03-15 1:29 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314205250.GC7241@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).