From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: fstests@vger.kernel.org, Scott Mayhew <smayhew@redhat.com>,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH xfstests] generic/035: Override output for NFS testing
Date: Tue, 3 Apr 2018 02:45:40 -0700 [thread overview]
Message-ID: <20180403094540.GA2254@infradead.org> (raw)
In-Reply-To: <e82df2bc4db926b051307ba4066d77b616c79b0c.1522337478.git.bcodding@redhat.com>
On Thu, Mar 29, 2018 at 11:34:39AM -0400, Benjamin Coddington wrote:
> We'd like to run generic tests for NFS, but often have slightly different
> output for our results. One instance is that for the NFS client the
> removal of an open file or directory is handled differently than for a
> local filesystem. We can expect nlink to be 1 for files, and to receive
> -ESTALE for operations on deleted directories, isn't that silly?
NFS is simply buggy in this case, and we should at least xfail the test
case, not make it look fine.
I'd rather have a file that lists expected fails per file system with an
explanation than a hack like this that papers over the issue.
next prev parent reply other threads:[~2018-04-03 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 15:34 [PATCH xfstests] generic/035: Override output for NFS testing Benjamin Coddington
2018-03-30 14:41 ` Anna Schumaker
2018-04-03 9:03 ` Eryu Guan
2018-04-03 9:45 ` Christoph Hellwig [this message]
2018-04-03 12:02 ` Trond Myklebust
2018-04-03 12:10 ` Benjamin Coddington
2018-04-03 12:25 ` Christoph Hellwig
2018-04-03 12:36 ` Benjamin Coddington
2018-04-03 14:48 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403094540.GA2254@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@Netapp.com \
--cc=bcodding@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).