* [PATCH] fs: nfs: Adding new return type vm_fault_t
@ 2018-04-14 19:44 Souptick Joarder
2018-05-11 18:30 ` Souptick Joarder
0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-04-14 19:44 UTC (permalink / raw)
To: trond.myklebust, anna.schumaker; +Cc: linux-nfs, willy
Use new return type vm_fault_t for page_mkwrite
handler.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
---
fs/nfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 81cca49..29553fd 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -532,13 +532,13 @@ static void nfs_swap_deactivate(struct file *file)
* writable, implying that someone is about to modify the page through a
* shared-writable mapping
*/
-static int nfs_vm_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf)
{
struct page *page = vmf->page;
struct file *filp = vmf->vma->vm_file;
struct inode *inode = file_inode(filp);
unsigned pagelen;
- int ret = VM_FAULT_NOPAGE;
+ vm_fault_t ret = VM_FAULT_NOPAGE;
struct address_space *mapping;
dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: nfs: Adding new return type vm_fault_t
2018-04-14 19:44 [PATCH] fs: nfs: Adding new return type vm_fault_t Souptick Joarder
@ 2018-05-11 18:30 ` Souptick Joarder
2018-05-23 11:54 ` Souptick Joarder
0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-05-11 18:30 UTC (permalink / raw)
To: trond.myklebust, anna.schumaker; +Cc: linux-nfs, Matthew Wilcox
On Sun, Apr 15, 2018 at 1:14 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Use new return type vm_fault_t for page_mkwrite
> handler.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
> fs/nfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/file.c b/fs/nfs/file.c
> index 81cca49..29553fd 100644
> --- a/fs/nfs/file.c
> +++ b/fs/nfs/file.c
> @@ -532,13 +532,13 @@ static void nfs_swap_deactivate(struct file *file)
> * writable, implying that someone is about to modify the page through a
> * shared-writable mapping
> */
> -static int nfs_vm_page_mkwrite(struct vm_fault *vmf)
> +static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf)
> {
> struct page *page = vmf->page;
> struct file *filp = vmf->vma->vm_file;
> struct inode *inode = file_inode(filp);
> unsigned pagelen;
> - int ret = VM_FAULT_NOPAGE;
> + vm_fault_t ret = VM_FAULT_NOPAGE;
> struct address_space *mapping;
>
> dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n",
> --
> 1.9.1
>
Any comment for this patch ? We would like to get this patch
queued for 4.18.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: nfs: Adding new return type vm_fault_t
2018-05-11 18:30 ` Souptick Joarder
@ 2018-05-23 11:54 ` Souptick Joarder
0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2018-05-23 11:54 UTC (permalink / raw)
To: trond.myklebust, anna.schumaker; +Cc: linux-nfs, Matthew Wilcox
On Sat, May 12, 2018 at 12:00 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> On Sun, Apr 15, 2018 at 1:14 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> Use new return type vm_fault_t for page_mkwrite
>> handler.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
>> ---
>> fs/nfs/file.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfs/file.c b/fs/nfs/file.c
>> index 81cca49..29553fd 100644
>> --- a/fs/nfs/file.c
>> +++ b/fs/nfs/file.c
>> @@ -532,13 +532,13 @@ static void nfs_swap_deactivate(struct file *file)
>> * writable, implying that someone is about to modify the page through a
>> * shared-writable mapping
>> */
>> -static int nfs_vm_page_mkwrite(struct vm_fault *vmf)
>> +static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf)
>> {
>> struct page *page = vmf->page;
>> struct file *filp = vmf->vma->vm_file;
>> struct inode *inode = file_inode(filp);
>> unsigned pagelen;
>> - int ret = VM_FAULT_NOPAGE;
>> + vm_fault_t ret = VM_FAULT_NOPAGE;
>> struct address_space *mapping;
>>
>> dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n",
>> --
>> 1.9.1
>>
>
> Any comment for this patch ? We would like to get this patch
> queued for 4.18.
If no comment, We would like to get this patch in queue for 4.18.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fs: nfs: Adding new return type vm_fault_t
@ 2018-07-02 15:27 Souptick Joarder
0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2018-07-02 15:27 UTC (permalink / raw)
To: akpm; +Cc: trond.myklebust, anna.schumaker, linux-nfs, linux-kernel, willy
Use new return type vm_fault_t for fault handler
in struct vm_operations_struct. For now, this is
just documenting that the function returns a
VM_FAULT value rather than an errno. Once all
instances are converted, vm_fault_t will become
a distinct type.
see commit 1c8f422059ae ("mm: change return type to
vm_fault_t") for reference.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
---
fs/nfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 81cca49..29553fd 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -532,13 +532,13 @@ static void nfs_swap_deactivate(struct file *file)
* writable, implying that someone is about to modify the page through a
* shared-writable mapping
*/
-static int nfs_vm_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf)
{
struct page *page = vmf->page;
struct file *filp = vmf->vma->vm_file;
struct inode *inode = file_inode(filp);
unsigned pagelen;
- int ret = VM_FAULT_NOPAGE;
+ vm_fault_t ret = VM_FAULT_NOPAGE;
struct address_space *mapping;
dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-02 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-14 19:44 [PATCH] fs: nfs: Adding new return type vm_fault_t Souptick Joarder
2018-05-11 18:30 ` Souptick Joarder
2018-05-23 11:54 ` Souptick Joarder
-- strict thread matches above, loose matches on Subject: below --
2018-07-02 15:27 Souptick Joarder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).