From: Michal Hocko <mhocko@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: LKML <linux-kernel@vger.kernel.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Steven Whitehouse <swhiteho@redhat.com>,
Bob Peterson <rpeterso@redhat.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-mtd@lists.infradead.org, linux-ext4@vger.kernel.org,
cluster-devel@redhat.com, linux-nfs@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: vmalloc with GFP_NOFS
Date: Tue, 24 Apr 2018 17:09:43 -0600 [thread overview]
Message-ID: <20180424230943.GY17484@dhcp22.suse.cz> (raw)
In-Reply-To: <3894056.cxOY6eVYVp@blindfold>
On Wed 25-04-18 00:18:40, Richard Weinberger wrote:
> Am Dienstag, 24. April 2018, 21:28:03 CEST schrieb Michal Hocko:
> > > Also only for debugging.
> > > Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem.
> > > I can prepare a patch.
> >
> > Cool!
> >
> > Anyway, if UBIFS has some reclaim recursion critical sections in general
> > it would be really great to have them documented and that is where the
> > scope api is really handy. Just add the scope and document what is the
> > recursion issue. This will help people reading the code as well. Ideally
> > there shouldn't be any explicit GFP_NOFS in the code.
>
> So in a perfect world a filesystem calls memalloc_nofs_save/restore and
> always uses GFP_KERNEL for kmalloc/vmalloc?
Exactly! And in a dream world those memalloc_nofs_save act as a
documentation of the reclaim recursion documentation ;)
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-04-24 23:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 16:27 vmalloc with GFP_NOFS Michal Hocko
2018-04-24 16:46 ` Mikulas Patocka
2018-04-24 16:55 ` Michal Hocko
2018-04-24 17:05 ` Mikulas Patocka
2018-04-24 18:35 ` Theodore Y. Ts'o
2018-04-24 19:25 ` Michal Hocko
2018-05-09 13:42 ` Michal Hocko
2018-05-09 14:13 ` David Sterba
2018-05-09 15:13 ` Darrick J. Wong
2018-05-09 16:24 ` Mike Rapoport
2018-05-09 21:06 ` Michal Hocko
2018-05-09 21:04 ` Michal Hocko
2018-05-09 22:02 ` Darrick J. Wong
2018-05-10 5:58 ` Michal Hocko
2018-05-10 7:18 ` Michal Hocko
2018-07-17 12:49 ` Michal Hocko
2018-04-24 19:10 ` Richard Weinberger
2018-04-24 19:26 ` Steven Whitehouse
2018-04-24 20:09 ` Michal Hocko
2018-07-17 12:50 ` Michal Hocko
[not found] ` <3732370.1623zxSvNg@blindfold>
2018-04-24 19:28 ` Michal Hocko
2018-04-24 22:18 ` Richard Weinberger
2018-04-24 23:09 ` Michal Hocko [this message]
2018-04-24 23:17 ` Mikulas Patocka
2018-04-24 23:25 ` Michal Hocko
2018-04-25 12:43 ` Mikulas Patocka
2018-04-25 14:45 ` Michal Hocko
2018-04-25 15:25 ` Mikulas Patocka
2018-04-25 16:56 ` Michal Hocko
2018-07-17 12:47 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424230943.GY17484@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=anna.schumaker@netapp.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cluster-devel@redhat.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mpatocka@redhat.com \
--cc=pombredanne@nexb.com \
--cc=richard@nod.at \
--cc=rpeterso@redhat.com \
--cc=swhiteho@redhat.com \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).