From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:38596 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940255AbeE1QkB (ORCPT ); Mon, 28 May 2018 12:40:01 -0400 Received: by mail-wr0-f195.google.com with SMTP id 94-v6so21177099wrf.5 for ; Mon, 28 May 2018 09:40:00 -0700 (PDT) Date: Mon, 28 May 2018 10:39:49 -0600 From: Jason Gunthorpe To: Greg Thelen Cc: arnd@arndb.de, Doug Ledford , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, Steve French , ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net, "David S. Miller" , santosh.shilimkar@oracle.com, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, bfields@fieldses.org, jlayton@kernel.org, Bart Van Assche , linux-rdma@vger.kernel.org, LKML , linux-nvme@lists.infradead.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies" Message-ID: <20180528163949.GA17505@ziepe.ca> References: <20180525213123.2113748-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: > On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: > > > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a > > link error when another driver using it is built-in. The > > INFINIBAND_ADDR_TRANS dependency is insufficient here as this is > > a 'bool' symbol that does not force anything to be a module in turn. > > > fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work': > > smbdirect.c:(.text+0x1e4): undefined reference to `rdma_disconnect' > > net/9p/trans_rdma.o: In function `rdma_request': > > trans_rdma.c:(.text+0x7bc): undefined reference to `rdma_disconnect' > > net/9p/trans_rdma.o: In function `rdma_destroy_trans': > > trans_rdma.c:(.text+0x830): undefined reference to `ib_destroy_qp' > > trans_rdma.c:(.text+0x858): undefined reference to `ib_dealloc_pd' > > > Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig > dependencies") > > Signed-off-by: Arnd Bergmann > > Acked-by: Greg Thelen > > Sorry for the 9533b292a7ac problem. > At this point the in release cycle, I think Arnd's revert is best. > > If there is interest, I've put a little thought into an alternative fix: > making INFINIBAND_ADDR_TRANS tristate. But it's nontrivial. > So I prefer this simple revert for now. Is that a normal thing to do? > Doug: do you need anything from me on this? I can take the revert.. Jason