From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:35444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965614AbeE2TNR (ORCPT ); Tue, 29 May 2018 15:13:17 -0400 Date: Tue, 29 May 2018 15:13:15 -0400 From: "J. Bruce Fields" To: Chuck Lever Cc: Linux NFS Mailing List Subject: Re: Fwd: [PATCH RFC 0/4] Use correct NFSv4.0 callback credential Message-ID: <20180529191315.GA31484@parsley.fieldses.org> References: <1526659388.10011.10.camel@redhat.com> <35C7F5A1-5192-4F00-B2C9-1BDFD5C00C94@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <35C7F5A1-5192-4F00-B2C9-1BDFD5C00C94@oracle.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, May 29, 2018 at 02:21:58PM -0400, Chuck Lever wrote: > > > > Begin forwarded message: > > > > From: Simo Sorce > > Subject: Re: [PATCH RFC 0/4] Use correct NFSv4.0 callback credential > > Date: May 18, 2018 at 12:03:08 PM EDT > > To: Chuck Lever , linux-nfs@vger.kernel.org > > > > On Fri, 2018-05-18 at 11:39 -0400, Chuck Lever wrote: > >> I've been experimenting with this series that modifies NFSD to > >> discover and use the correct GSS service principal when constructing > >> its NFSv4.0 callback channels. I'm interested in review of this > >> approach. There are a couple of code comments marked with XXX that > >> also need some attention. > >> > >> The rpc.gssd change mentioned in 1/4 is unremarkable and will be > >> made available once there is consensus about the kernel changes > >> in this series. No gssproxy changes are necessary. > >> > >> --- > >> > >> Chuck Lever (4): > >> sunrpc: Enable the kernel to specify the hostname part of service principals > >> sunrpc: Extract target name into svc_cred > >> nfsd: Use correct credential for NFSv4.0 callback with GSS > >> nfsd: Remove callback_cred > >> > >> > >> fs/nfsd/nfs4callback.c | 29 ++++---------- > >> fs/nfsd/nfs4state.c | 17 +++----- > >> fs/nfsd/state.h | 2 - > >> include/linux/sunrpc/svcauth.h | 3 + > >> net/sunrpc/auth_gss/auth_gss.c | 20 ++++++++-- > >> net/sunrpc/auth_gss/gss_rpc_upcall.c | 70 ++++++++++++++++++++++------------ > >> 6 files changed, 80 insertions(+), 61 deletions(-) > >> > >> -- > >> Chuck Lever > > > > Ack for the sunrpc gssp changes. > > Hi Bruce, are you willing to take this series for v4.18? Sure. Are you going to repost? > If so, I can post the gssd patch that goes with it. Sounds good. --b.