From: "J. Bruce Fields" <bfields@redhat.com>
To: Olga Kornievskaia <aglo@umich.edu>
Cc: Olga Kornievskaia <kolga@netapp.com>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v9 0/9] NFSD support for async COPY
Date: Thu, 12 Jul 2018 15:16:45 -0400 [thread overview]
Message-ID: <20180712191645.GC10033@parsley.fieldses.org> (raw)
In-Reply-To: <CAN-5tyFeuDxTFTpM_-ZJp27sc87A1TU0ToDJxb2Kw4jTGFA+-A@mail.gmail.com>
On Thu, Jul 12, 2018 at 03:11:14PM -0400, Olga Kornievskaia wrote:
> On Thu, Jul 12, 2018 at 2:56 PM, J. Bruce Fields <bfields@redhat.com> wrote:
> > I think we got confused in the previous discussion of this.
> >
> > The reason I wanted the module parameter was that server-to-server copy
> > would allow a rogue client to direct the server to copy from any server
> > it wishes, and I thought this was potentially risky, and want people to
> > opt into it rather than having it the default.
> >
> > That doesn't apply to asynchronous copy on its own.
> >
> > So this module parameter could wait for the next patchset.
>
> To clarify, you want "inter" copy offload to be configuration, but it
> already was (when it was first posted) under config option. Now
> instead of a compile option you prefer this to be a module parameter?
That's right.
I'd like distributions to be able to include server-to-server-copy
capable kernels, but I don't want it on by default because I think
responsible administrators will want to do some firewalling first.
> Do you have any other comments? I'd rather not re-post another version
> if you have more comments.
In that case I'd recommend holding off till next week.
--b.
next prev parent reply other threads:[~2018-07-12 19:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 19:26 [PATCH v9 0/9] NFSD support for async COPY Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 1/9] NFSD CB_OFFLOAD xdr Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 2/9] NFSD OFFLOAD_STATUS xdr Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 3/9] NFSD OFFLOAD_CANCEL xdr Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 4/9] NFSD xdr callback stateid in async COPY reply Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 5/9] NFSD introduce async copy feature Olga Kornievskaia
2018-07-12 21:18 ` J. Bruce Fields
2018-07-09 19:26 ` [PATCH v9 6/9] NFSD create new stateid for async copy Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 7/9] NFSD handle OFFLOAD_CANCEL op Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 8/9] NFSD support OFFLOAD_STATUS Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 9/9] NFSD stop ongoing async copies on client shutdown Olga Kornievskaia
2018-07-12 18:56 ` [PATCH v9 0/9] NFSD support for async COPY J. Bruce Fields
2018-07-12 19:11 ` Olga Kornievskaia
2018-07-12 19:16 ` J. Bruce Fields [this message]
2018-07-15 22:52 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712191645.GC10033@parsley.fieldses.org \
--to=bfields@redhat.com \
--cc=aglo@umich.edu \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).