linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: Olga Kornievskaia <kolga@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v9 5/9] NFSD introduce async copy feature
Date: Thu, 12 Jul 2018 17:18:41 -0400	[thread overview]
Message-ID: <20180712211840.GA31361@parsley.fieldses.org> (raw)
In-Reply-To: <20180709192638.44799-6-kolga@netapp.com>

On Mon, Jul 09, 2018 at 03:26:34PM -0400, Olga Kornievskaia wrote:
> +static __be32 nfsd4_init_copy_res(struct nfsd4_copy *copy, bool sync)
> +{
> +	memcpy(&copy->cp_res.cb_stateid, &copy->cp_dst_stateid,
> +		sizeof(copy->cp_dst_stateid));
> +	copy->cp_res.wr_stable_how = NFS_UNSTABLE;
> +	copy->cp_synchronous = sync;
> +	gen_boot_verifier(&copy->cp_res.wr_verifier, copy->cp_clp->net);
> +
> +	return nfs_ok;

Just make this return void if you're not using the error return.

--b.

  reply	other threads:[~2018-07-12 21:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 19:26 [PATCH v9 0/9] NFSD support for async COPY Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 1/9] NFSD CB_OFFLOAD xdr Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 2/9] NFSD OFFLOAD_STATUS xdr Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 3/9] NFSD OFFLOAD_CANCEL xdr Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 4/9] NFSD xdr callback stateid in async COPY reply Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 5/9] NFSD introduce async copy feature Olga Kornievskaia
2018-07-12 21:18   ` J. Bruce Fields [this message]
2018-07-09 19:26 ` [PATCH v9 6/9] NFSD create new stateid for async copy Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 7/9] NFSD handle OFFLOAD_CANCEL op Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 8/9] NFSD support OFFLOAD_STATUS Olga Kornievskaia
2018-07-09 19:26 ` [PATCH v9 9/9] NFSD stop ongoing async copies on client shutdown Olga Kornievskaia
2018-07-12 18:56 ` [PATCH v9 0/9] NFSD support for async COPY J. Bruce Fields
2018-07-12 19:11   ` Olga Kornievskaia
2018-07-12 19:16     ` J. Bruce Fields
2018-07-15 22:52       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712211840.GA31361@parsley.fieldses.org \
    --to=bfields@redhat.com \
    --cc=kolga@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).