From: Christoph Hellwig <hch@infradead.org>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] rpc.gssd: truncates 32-bit UIDs/GIDs to 16 bits architectures.
Date: Wed, 18 Jul 2018 05:33:03 -0700 [thread overview]
Message-ID: <20180718123303.GA2749@infradead.org> (raw)
In-Reply-To: <20180718121107.16838-1-steved@redhat.com>
> - if (syscall(SYS_setresgid, pw->pw_gid, pw->pw_gid, pw->pw_gid) != 0) {
> +#ifdef __NR_setresuid32
> + res = syscall(SYS_setresgid32, pw->pw_gid, pw->pw_gid, pw->pw_gid);
> +#else
> + res = syscall(SYS_setresgid, pw->pw_gid, pw->pw_gid, pw->pw_gid);
> +#endif
I think you want to simply call setresuid/setresgid from glibcs, which
will do the right thing instead of doing hand crafted syscalls.
next prev parent reply other threads:[~2018-07-18 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 12:11 [PATCH] rpc.gssd: truncates 32-bit UIDs/GIDs to 16 bits architectures Steve Dickson
2018-07-18 12:33 ` Christoph Hellwig [this message]
2018-07-18 14:26 ` Steve Dickson
2018-07-18 15:27 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718123303.GA2749@infradead.org \
--to=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox