* [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id
@ 2018-07-23 1:57 nixiaoming
2018-08-01 15:18 ` J. Bruce Fields
0 siblings, 1 reply; 4+ messages in thread
From: nixiaoming @ 2018-07-23 1:57 UTC (permalink / raw)
To: bfields, jlayton, chuck.lever, trondmy, andros
Cc: linux-nfs, linux-kernel, nixiaoming
READ_BUF(8);
dummy = be32_to_cpup(p++);
dummy = be32_to_cpup(p++);
...
READ_BUF(4);
dummy = be32_to_cpup(p++);
Assigning value to "dummy" here, but that stored value
is overwritten before it can be used.
At the same time READ_BUF() will re-update the pointer p.
delete invalid assignment statements
Signed-off-by: nixiaoming <nixiaoming@huawei.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <trondmy@hammerspace.com>
---
fs/nfsd/nfs4xdr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index a96843c..375ad4b 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1392,8 +1392,6 @@ nfsd4_decode_exchange_id(struct nfsd4_compoundargs *argp,
/* ssp_window and ssp_num_gss_handles */
READ_BUF(8);
- dummy = be32_to_cpup(p++);
- dummy = be32_to_cpup(p++);
break;
default:
goto xdr_error;
--
2.10.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id
2018-07-23 1:57 [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id nixiaoming
@ 2018-08-01 15:18 ` J. Bruce Fields
2018-08-02 13:00 ` Nixiaoming
0 siblings, 1 reply; 4+ messages in thread
From: J. Bruce Fields @ 2018-08-01 15:18 UTC (permalink / raw)
To: nixiaoming; +Cc: jlayton, chuck.lever, trondmy, andros, linux-nfs, linux-kernel
On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote:
> READ_BUF(8);
> dummy = be32_to_cpup(p++);
> dummy = be32_to_cpup(p++);
> ...
> READ_BUF(4);
> dummy = be32_to_cpup(p++);
>
> Assigning value to "dummy" here, but that stored value
> is overwritten before it can be used.
> At the same time READ_BUF() will re-update the pointer p.
>
> delete invalid assignment statements
Thanks, applying with a minor comment tweak to clarify that we're
intentionally not reading these:
- /* ssp_window and ssp_num_gss_handles */
+ /* ignore ssp_window and ssp_num_gss_handles: */
READ_BUF(8);
break;
--b.
>
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Trond Myklebust <trondmy@hammerspace.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index a96843c..375ad4b 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -1392,8 +1392,6 @@ nfsd4_decode_exchange_id(struct nfsd4_compoundargs *argp,
>
> /* ssp_window and ssp_num_gss_handles */
> READ_BUF(8);
> - dummy = be32_to_cpup(p++);
> - dummy = be32_to_cpup(p++);
> break;
> default:
> goto xdr_error;
> --
> 2.10.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id
2018-08-01 15:18 ` J. Bruce Fields
@ 2018-08-02 13:00 ` Nixiaoming
2018-08-02 13:19 ` J. Bruce Fields
0 siblings, 1 reply; 4+ messages in thread
From: Nixiaoming @ 2018-08-02 13:00 UTC (permalink / raw)
To: J. Bruce Fields
Cc: jlayton@kernel.org, chuck.lever@oracle.com,
trondmy@hammerspace.com, andros@netapp.com,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
On Wednesday, August 01, 2018 11:18 PM , J. Bruce Fields wrote:
>On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote:
>> READ_BUF(8);
>> dummy = be32_to_cpup(p++);
>> dummy = be32_to_cpup(p++);
>> ...
>> READ_BUF(4);
>> dummy = be32_to_cpup(p++);
>>
>> Assigning value to "dummy" here, but that stored value
>> is overwritten before it can be used.
>> At the same time READ_BUF() will re-update the pointer p.
>>
>> delete invalid assignment statements
>
>Thanks, applying with a minor comment tweak to clarify that we're
>intentionally not reading these:
>
>- /* ssp_window and ssp_num_gss_handles */
>+ /* ignore ssp_window and ssp_num_gss_handles: */
> READ_BUF(8);
> break;
>
>--b.
>
Thanks for your advice
I will update the patch as soon as possible according to your advice.
>>
>> Signed-off-by: nixiaoming <nixiaoming@huawei.com>
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>2
>> Signed-off-by: Trond Myklebust <trondmy@hammerspace.com>
>> ---
>> fs/nfsd/nfs4xdr.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
>> index a96843c..375ad4b 100644
>> --- a/fs/nfsd/nfs4xdr.c
>> +++ b/fs/nfsd/nfs4xdr.c
>> @@ -1392,8 +1392,6 @@ nfsd4_decode_exchange_id(struct nfsd4_compoundargs *argp,
>>
>> /* ssp_window and ssp_num_gss_handles */
>> READ_BUF(8);
>> - dummy = be32_to_cpup(p++);
>> - dummy = be32_to_cpup(p++);
>> break;
>> default:
>> goto xdr_error;
>> --
>> 2.10.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id
2018-08-02 13:00 ` Nixiaoming
@ 2018-08-02 13:19 ` J. Bruce Fields
0 siblings, 0 replies; 4+ messages in thread
From: J. Bruce Fields @ 2018-08-02 13:19 UTC (permalink / raw)
To: Nixiaoming
Cc: jlayton@kernel.org, chuck.lever@oracle.com,
trondmy@hammerspace.com, andros@netapp.com,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
On Thu, Aug 02, 2018 at 01:00:26PM +0000, Nixiaoming wrote:
> On Wednesday, August 01, 2018 11:18 PM , J. Bruce Fields wrote:
> >On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote:
> >> READ_BUF(8);
> >> dummy = be32_to_cpup(p++);
> >> dummy = be32_to_cpup(p++);
> >> ...
> >> READ_BUF(4);
> >> dummy = be32_to_cpup(p++);
> >>
> >> Assigning value to "dummy" here, but that stored value
> >> is overwritten before it can be used.
> >> At the same time READ_BUF() will re-update the pointer p.
> >>
> >> delete invalid assignment statements
> >
> >Thanks, applying with a minor comment tweak to clarify that we're
> >intentionally not reading these:
> >
> >- /* ssp_window and ssp_num_gss_handles */
> >+ /* ignore ssp_window and ssp_num_gss_handles: */
> > READ_BUF(8);
> > break;
> >
> >--b.
> >
>
> Thanks for your advice
> I will update the patch as soon as possible according to your advice.
I've taken care of it, no need to update.
--b.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-02 15:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-23 1:57 [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id nixiaoming
2018-08-01 15:18 ` J. Bruce Fields
2018-08-02 13:00 ` Nixiaoming
2018-08-02 13:19 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).