From: "J. Bruce Fields" <bfields@redhat.com>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Turn ENOATTR errors into ENODATA errrors
Date: Wed, 1 Aug 2018 16:59:52 -0400 [thread overview]
Message-ID: <20180801205951.GE19925@parsley.fieldses.org> (raw)
In-Reply-To: <20180801184052.21215-1-steved@redhat.com>
Applied, thanks.--b.
On Wed, Aug 01, 2018 at 02:40:52PM -0400, Steve Dickson wrote:
> The defining of ENOATTR, which was an defined as ENODATA,
> was removed from the attr/xattr.h in modern releases
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> libnfs4acl/nfs4_acl_for_path.c | 2 +-
> libnfs4acl/nfs4_set_acl.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libnfs4acl/nfs4_acl_for_path.c b/libnfs4acl/nfs4_acl_for_path.c
> index a51dc34..2fbf6c9 100644
> --- a/libnfs4acl/nfs4_acl_for_path.c
> +++ b/libnfs4acl/nfs4_acl_for_path.c
> @@ -94,7 +94,7 @@ static int nfs4_getxattr(const char *path, void *value, size_t size)
> if (res < -10000) {
> fprintf(stderr,"An internal NFS server error code (%d) was returned; this should never happen.\n",res);
> } else if (res < 0) {
> - if (errno == ENOATTR)
> + if (errno == ENODATA)
> fprintf(stderr,"Attribute not found on file: %s\n", path);
> else if (errno == EREMOTEIO)
> fprintf(stderr,"An NFS server error occurred.\n");
> diff --git a/libnfs4acl/nfs4_set_acl.c b/libnfs4acl/nfs4_set_acl.c
> index b9edf2b..6c9b072 100644
> --- a/libnfs4acl/nfs4_set_acl.c
> +++ b/libnfs4acl/nfs4_set_acl.c
> @@ -55,7 +55,7 @@ int nfs4_set_acl(struct nfs4_acl *acl, const char *path)
> } else if (res < 0) {
> if (errno == EOPNOTSUPP)
> fprintf(stderr,"Operation to set ACL not supported.\n");
> - else if (errno == ENOATTR)
> + else if (errno == ENODATA)
> fprintf(stderr,"ACL Attribute not found on file.\n");
> else if (errno == EREMOTEIO)
> fprintf(stderr,"An NFS server error occurred.\n");
> --
> 2.17.1
>
prev parent reply other threads:[~2018-08-01 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 18:40 [PATCH] Turn ENOATTR errors into ENODATA errrors Steve Dickson
2018-08-01 20:59 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801205951.GE19925@parsley.fieldses.org \
--to=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).