From: "J. Bruce Fields" <bfields@fieldses.org>
To: Nixiaoming <nixiaoming@huawei.com>
Cc: "jlayton@kernel.org" <jlayton@kernel.org>,
"chuck.lever@oracle.com" <chuck.lever@oracle.com>,
"trondmy@hammerspace.com" <trondmy@hammerspace.com>,
"andros@netapp.com" <andros@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id
Date: Thu, 2 Aug 2018 09:19:51 -0400 [thread overview]
Message-ID: <20180802131951.GA30706@fieldses.org> (raw)
In-Reply-To: <E490CD805F7529488761C40FD9D26EF12A730A64@dggemm507-mbx.china.huawei.com>
On Thu, Aug 02, 2018 at 01:00:26PM +0000, Nixiaoming wrote:
> On Wednesday, August 01, 2018 11:18 PM , J. Bruce Fields wrote:
> >On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote:
> >> READ_BUF(8);
> >> dummy = be32_to_cpup(p++);
> >> dummy = be32_to_cpup(p++);
> >> ...
> >> READ_BUF(4);
> >> dummy = be32_to_cpup(p++);
> >>
> >> Assigning value to "dummy" here, but that stored value
> >> is overwritten before it can be used.
> >> At the same time READ_BUF() will re-update the pointer p.
> >>
> >> delete invalid assignment statements
> >
> >Thanks, applying with a minor comment tweak to clarify that we're
> >intentionally not reading these:
> >
> >- /* ssp_window and ssp_num_gss_handles */
> >+ /* ignore ssp_window and ssp_num_gss_handles: */
> > READ_BUF(8);
> > break;
> >
> >--b.
> >
>
> Thanks for your advice
> I will update the patch as soon as possible according to your advice.
I've taken care of it, no need to update.
--b.
prev parent reply other threads:[~2018-08-02 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 1:57 [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id nixiaoming
2018-08-01 15:18 ` J. Bruce Fields
2018-08-02 13:00 ` Nixiaoming
2018-08-02 13:19 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802131951.GA30706@fieldses.org \
--to=bfields@fieldses.org \
--cc=andros@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).