Re: [PATCH RFC 0/4] Use correct NFSv4.0 callback credential

["J. Bruce Fields" <bfields@redhat.com>]

On Wed, Aug 15, 2018 at 06:27:36PM -0400, Chuck Lever wrote:
> 
> 
> > On May 29, 2018, at 3:14 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
> > 
> > 
> > 
> >> On May 29, 2018, at 3:13 PM, J. Bruce Fields <bfields@redhat.com> wrote:
> >> 
> >> On Tue, May 29, 2018 at 02:21:58PM -0400, Chuck Lever wrote:
> >>> 
> >>> 
> >>>> Begin forwarded message:
> >>>> 
> >>>> From: Simo Sorce <simo@redhat.com>
> >>>> Subject: Re: [PATCH RFC 0/4] Use correct NFSv4.0 callback credential
> >>>> Date: May 18, 2018 at 12:03:08 PM EDT
> >>>> To: Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
> >>>> 
> >>>> On Fri, 2018-05-18 at 11:39 -0400, Chuck Lever wrote:
> >>>>> I've been experimenting with this series that modifies NFSD to
> >>>>> discover and use the correct GSS service principal when constructing
> >>>>> its NFSv4.0 callback channels. I'm interested in review of this
> >>>>> approach. There are a couple of code comments marked with XXX that
> >>>>> also need some attention.
> >>>>> 
> >>>>> The rpc.gssd change mentioned in 1/4 is unremarkable and will be
> >>>>> made available once there is consensus about the kernel changes
> >>>>> in this series. No gssproxy changes are necessary.
> >>>>> 
> >>>>> ---
> >>>>> 
> >>>>> Chuck Lever (4):
> >>>>>    sunrpc: Enable the kernel to specify the hostname part of service principals
> >>>>>    sunrpc: Extract target name into svc_cred
> >>>>>    nfsd: Use correct credential for NFSv4.0 callback with GSS
> >>>>>    nfsd: Remove callback_cred
> >>>>> 
> >>>>> 
> >>>>> fs/nfsd/nfs4callback.c               |   29 ++++----------
> >>>>> fs/nfsd/nfs4state.c                  |   17 +++-----
> >>>>> fs/nfsd/state.h                      |    2 -
> >>>>> include/linux/sunrpc/svcauth.h       |    3 +
> >>>>> net/sunrpc/auth_gss/auth_gss.c       |   20 ++++++++--
> >>>>> net/sunrpc/auth_gss/gss_rpc_upcall.c |   70 ++++++++++++++++++++++------------
> >>>>> 6 files changed, 80 insertions(+), 61 deletions(-)
> >>>>> 
> >>>>> --
> >>>>> Chuck Lever
> >>>> 
> >>>> Ack for the sunrpc gssp changes.
> >>> 
> >>> Hi Bruce, are you willing to take this series for v4.18?
> >> 
> >> Sure.  Are you going to repost?
> > 
> > Except for Simo's Ack, there haven't been any requests for
> > changes, so I hadn't planned to repost. But it wouldn't be
> > a problem if you'd like me to post again.
> 
> Hi Bruce-
> 
> I don't see these patches in v4.18 nor in your nfsd-next tree.
> Did they get dropped?

Apologies, I think so, could you repost?

--b.