From: bfields@fieldses.org (J. Bruce Fields)
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: Olga Kornievskaia <kolga@netapp.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v10 0/9] NFSD support for async COPY
Date: Wed, 22 Aug 2018 21:47:22 -0400 [thread overview]
Message-ID: <20180823014722.GA24441@fieldses.org> (raw)
In-Reply-To: <20180809203450.GE14104@parsley.fieldses.org>
On Thu, Aug 09, 2018 at 04:34:50PM -0400, J. Bruce Fields wrote:
> Thanks, I've added these to my -next branch, and I want to read through
> them tomorrow.
Gah, I screwed up and took to long to get around to this and have a few
things I'd like to change, so I'm going to queue these up again for
4.20.
The way the patches are broken up doesn't really work; for example
init_cp_state is used in one but patch not defined till a later patch,
and waiting till the last patch to cleanup on client expiry leaves us
with a bug until that patch is applied. I'm not seeing a better way to
split things up so I think best is just to glom them all together, which
I've gone ahead and done. (The XDR patches are still separate, I'm not
sure how much that helps but I think it's harmless.)
I'm not sure about the signalling--I don't see anything else outside
core code setting TIF_SIGPENDING directly, is that really all we need to
do? I know it was me that asked for signalling there, but for now let's
just rely on kthread_stop. If somebody can explain to me how we're
supposed to do the signalling, we can do that, but then we should rely
on it alone and not do both that and kthread_stop.
That's a minor change so I did that as well, hope that's OK. Results
are in my linux-next branch. I'm also happy to look at the
server-to-server patches on top of that if they're ready.
--b.
next prev parent reply other threads:[~2018-08-23 5:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 22:19 [PATCH v10 0/9] NFSD support for async COPY Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 1/9] NFSD CB_OFFLOAD xdr Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 2/9] NFSD OFFLOAD_STATUS xdr Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 3/9] NFSD OFFLOAD_CANCEL xdr Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 4/9] NFSD xdr callback stateid in async COPY reply Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 5/9] NFSD introduce async copy feature Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 6/9] NFSD create new stateid for async copy Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 7/9] NFSD handle OFFLOAD_CANCEL op Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 8/9] NFSD support OFFLOAD_STATUS Olga Kornievskaia
2018-07-20 22:19 ` [PATCH v10 9/9] NFSD stop ongoing async copies on client shutdown Olga Kornievskaia
2018-08-09 20:34 ` [PATCH v10 0/9] NFSD support for async COPY J. Bruce Fields
2018-08-23 1:47 ` J. Bruce Fields [this message]
2018-08-23 12:22 ` J. Bruce Fields
2018-08-23 12:32 ` J. Bruce Fields
2018-08-23 18:30 ` Olga Kornievskaia
2018-09-05 14:30 ` Olga Kornievskaia
2018-09-05 15:56 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823014722.GA24441@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).